This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
remove installation psycopg python package #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Attached issue: https://pulp.plan.io/issues/6752 |
mikedep333
suggested changes
Oct 1, 2020
pavelpicka
force-pushed
the
6752-psycopg2
branch
from
26045b4
to
42f63d1
Compare
mikedep333
approved these changes
Oct 8, 2020
mikedep333
suggested changes
Oct 8, 2020
There was a problem hiding this comment.
Although not strictly within scope of the original issue, please also remove the instances where we set the variables for these distros:
roles/pulp_database/vars/Debian.yml:postgresql_python_library: python3-psycopg2
roles/pulp_database/vars/Ubuntu.yml:postgresql_python_library: python3-psycopg2
Because it appears that the geerlingguy.postgresql role sets them correctly.
pavelpicka
force-pushed
the
6752-psycopg2
branch
from
42f63d1
to
9d169dc
Compare
mikedep333
suggested changes
Oct 23, 2020
pavelpicka
force-pushed
the
6752-psycopg2
branch
from
9d169dc
to
ddb7117
Compare
mikedep333
approved these changes
Oct 23, 2020
|
@pavelpicka Per our convo, I caused the CI to fail with my merge commit (it checks for an issue #.) I was trying to close out easily closed PRs last week, and mistakenly thought the merge commit would work just fine. |
pavelpicka
changed the title
pavelpicka
force-pushed
the
6752-psycopg2
branch
from
28bb088
to
af2145a
Compare
python*-psycopg2 is installed by geerlingguy role so removed from docs as prerequisite fixed docs formatting closes: #6752 https://pulp.plan.io/issues/6752
pavelpicka
force-pushed
the
6752-psycopg2
branch
from
af2145a
to
01a3be7
Compare
mikedep333
approved these changes
Nov 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python*-psycopg2 is installed by geerlingguy role so removed from docs as prerequisite
closes: #6752
https://pulp.plan.io/issues/6752