Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Pulp 3 via systemd containers #45

Closed
wants to merge 2 commits into from

Conversation

ehelms
Copy link
Contributor

@ehelms ehelms commented Nov 1, 2018

This is a WIP by all means. However, this does generally work and hence why I am opening a starter PR for the work. This is set to work easily in conjunction with pulplift

git clone https://github.com/ehelms/pulplift
cd pulplift
./setup.sh
cd ansible-pulp3
wget https://github.com/pulp/ansible-pulp3/pull/45.patch
git am 45.patch
cd ../
vagrant up pulp3-containers-centos7

A few things to note about this current setup. This uses the existing containers built from my POC project repo carafe and live on quay.io. Those containers are built from git source and include both the Ansible and File plugins.

@ehelms
Copy link
Contributor Author

ehelms commented Nov 6, 2018

This will depend on the outcome of the images themselves -- pulp/pulp#3740

{% if pulp_container_deployment %}
[Unit]
Description=Pulp Resource Manager
Wants=syslog.service postgresql.service redis.service
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also want network-online.target? Could this be shared between the container and non-container definitions?

@ehelms ehelms changed the title [WIP] Systemd containers Deploy Pulp 3 via systemd containers Nov 21, 2018
@bmbouter
Copy link
Member

@ehelms I was not able to test this yet. Can the conflicts be resolved first?

@ehelms
Copy link
Contributor Author

ehelms commented Jan 25, 2019

Rebased on master to address the conflicts.

@ehelms ehelms force-pushed the systemd-containers branch 2 times, most recently from fef0aec to daf9276 Compare February 6, 2019 14:55
@ehelms
Copy link
Contributor Author

ehelms commented Feb 6, 2019

Updated to match recent updates to container PR (pulp/pulp#3740) with a few caveats that I will comment on inline.

package:
name: epel-release
state: present
when: ansible_distribution == 'CentOS'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be done here as it's independent of all other roles.

@@ -1,28 +1,56 @@
---
- block:
# Become root so as to search paths like /usr/sbin.
- name: Find the nologin executable
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally speaking, I had to move a chunk of install and configure around. This is not the prettiest solution currently. A container based setup needs some of the aspects a base install needs but not all. Mostly this is around configuration and data storage:

  • /etc/pulp
  • /var/lib/pulp

Those two need to be setup and configured prior to starting the containers.

pulp_install_dir: false
pulp_container_deployment: true
# CHANGE BEFORE COMMITTING
pulp_container_registry: quay.io/ehelms
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This allows testing of current state of images, but should not be merged.

@bmbouter
Copy link
Member

@ehelms I tested this some today, but there have been some changes to ansible-pulp3 so this need to be looked at. I read through the changes and they all look fine to me. I'm back from PTO so I'll be able to contribute more regularly now also.

@bmbouter
Copy link
Member

@pulp/ansible-installer this adds the capability to deploy via systemd-containers that are built using the Pulp build service made as part of this PR: pulp/pulp#3740

@cognifloyd
Copy link
Contributor

pulp/pulpcore#13 replaces pulp/pulp#3740

mikedep333 added a commit to mikedep333/pulplift that referenced this pull request May 15, 2019
They are dependent upon this PR that has yet to be merged:
pulp/pulp_installer#45
@mikedep333
Copy link
Member

FYI: We are removing these from pulplift:
pulp/pulplift#33

If this PR ever is accepted, just create a revert commit (with an updated list of distros).
https://pulp.plan.io/issues/4807

mikedep333 added a commit to mikedep333/pulplift that referenced this pull request May 15, 2019
They are dependent upon this PR that has yet to be merged:
pulp/pulp_installer#45

closes #4807
https://pulp.plan.io/issues/4807
@bmbouter
Copy link
Member

@mikedep333 @ehelms what do you want to do with this PR? I'm not sure where you want to take this work next (if anywhere).

@asmacdo
Copy link
Contributor

asmacdo commented Sep 16, 2019

AFAICT, this was the preliminary work that is now being done by pulp-operator. I'm closing, but feel free to reopen.

@asmacdo asmacdo closed this Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants