Adding ansible 3 support #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Attached issue: https://pulp.plan.io/issues/8365 |
|
@mikedep333 I changed 2 tests to use ansible 3 instead of 2.9, but these tests were marked as required. Could you please change the repo settings? |
mikedep333
requested changes
Mar 10, 2021
Comment on lines
23
to
31
| ansible.posix.firewalld: | ||
| port: '{{ pulp_webserver_http_port }}/tcp' | ||
| permanent: true | ||
| immediate: true | ||
| state: enabled | ||
| zone: '{{ pulp_firewalld_zone | default(omit) }}' | ||
|
|
||
| - name: Accept HTTPS connections on port {{ pulp_webserver_https_port }} | ||
| firewalld: | ||
| ansible.posix.firewalld: |
There was a problem hiding this comment.
Try out this syntax:
+++ b/roles/pulp_webserver/meta/main.yml
@@ -23,3 +23,5 @@ galaxy_info:
- pulpcore
dependencies:
- pulp_common
+collections:
+ - ansible.posix
It may cause the collection to be installed as a dependency.
I am almost certain it will eliminate the need to specify the FQCN.
mikedep333
requested changes
Mar 10, 2021
| @@ -0,0 +1 @@ | |||
| Adding ansible 3 support | |||
There was a problem hiding this comment.
We need to list dropping Ansible 2.8 support under removal. (Although it may technically work, but still.)
mikedep333
approved these changes
Mar 10, 2021
fao89
force-pushed
the
8365
branch
2 times, most recently
from
8a545b0
to
a3d6761
Compare
[noissue]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://pulp.plan.io/issues/8365
closes #8365