Declare collection dependencies #567
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[noissue]
fao89
commented
Mar 24, 2021
| @@ -54,6 +54,9 @@ tags: | |||
| # range specifiers can be set and are separated by ',' | |||
| dependencies: | |||
| ansible.posix: "*" | |||
| community.crypto: "*" | |||
| community.general: "*" | |||
| community.postgres: "*" | |||
There was a problem hiding this comment.
adding dependencies here will make ansible-galaxy install the dependencies, but some users don't use pulp_database role, therefore they would be installing community.postgres for nothing.
Not sure what would be the best way to deal with these "conditional dependencies"
There was a problem hiding this comment.
@fao89 Good point. I'm very curious if there is a way.
We do declare dependencies in the roles, maybe that can help.
There was a problem hiding this comment.
I'm wondering: should we vendor these "conditional dependencies"?
|
WARNING!!! This PR is not attached to an issue. In most cases this is not advisable. Please see our PR docs for more information about how to attach this PR to an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[noissue]