Making nginx and apache config use scheme #594
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WARNING!!! This PR is not attached to an issue. In most cases this is not advisable. Please see our PR docs for more information about how to attach this PR to an issue. |
fao89
force-pushed
the
8130
branch
3 times, most recently
from
c3730fd
to
957e02d
Compare
mdellweg
reviewed
Apr 18, 2021
roles/pulp_webserver/vars/main.yml
Outdated
Comment on lines
2
to
5
| __pulp_webserver_apache_api_bind: "{{ pulp_api_bind.startswith('unix') | ternary(pulp_api_bind + '|http://' + __pulp_default_host, 'http://' + pulp_api_bind ) }}" | ||
| __pulp_webserver_apache_content_bind: "{{ pulp_content_bind.startswith('unix') | ternary(pulp_content_bind + '|http://' + __pulp_default_host, 'http://' + pulp_content_bind ) }}" | ||
| __pulp_webserver_nginx_api_bind: "{{ pulp_api_bind.startswith('unix') | ternary(pulp_api_bind + '|http://' + __pulp_default_host, 'http://' + pulp_api_bind ) }}" | ||
| __pulp_webserver_nginx_content_bind: "{{ pulp_content_bind.startswith('unix') | ternary(pulp_content_bind + '|http://' + __pulp_default_host, 'http://' + pulp_content_bind ) }}" |
There was a problem hiding this comment.
Should the variable __pulp_default_host not be called __pulp_host.
Calling it default sounds like it can be overwritten when using the role, which contradicts the __ prefix.
fao89
force-pushed
the
8130
branch
2 times, most recently
from
53bdcf2
to
f4a745f
Compare
mikedep333
approved these changes
Apr 28, 2021
|
@fao89 Please rebase once more, to re-run CI. Then we can merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[noissue]