Switch devel env to use pulplift - Issue 4234 #61
Conversation
Added pulp3-devel role to the ansible-pulp3 repo re #4234 https://pulp.plan.io/issues/4234
CodeHeeler
force-pushed
the
issue-4234
branch
from
6f2b3c8
to
8d31f19
Compare
roles/pulp3/tasks/install.yml
Outdated
| @@ -99,5 +99,12 @@ | |||
| with_dict: '{{ pulp_install_plugins }}' | |||
| when: pulp_install_plugins[item.key].source_dir is defined | |||
|
|
|||
| - name: Install requirements for building docs | |||
There was a problem hiding this comment.
This is supposed to go into the pulp3-devel role. Otherwise these deps are going to be installed for users that are just installing pulp.
There was a problem hiding this comment.
Oops, good catch.
CodeHeeler
force-pushed
the
issue-4234
branch
2 times, most recently
from
1255a8a
to
5dcc273
Compare
| pulp_source_dir: "/home/vagrant/devel/pulp" | ||
| pulp_plugin_source_dir: "/home/vagrant/devel/pulpcore-plugin" | ||
| pulp_secret_key: "unsafe_default" | ||
| developer_user: "vagrant" |
There was a problem hiding this comment.
Source install will definitely be used by non-vagrant users. IMO, anything vagrant specific should should be in the Vagrantfile.source.example (maybe change that to Vagnrantfile.dev.example)
There was a problem hiding this comment.
Ah, nevermind. I already screwed this up by including the vagrant-pretask. We'll need to revisit which playbooks/Vagrantfiles are provided by us, and specify what they are intended for (ie, as an example to be changed, or as a playbook for developer environments, etc). However, since I already blurred the line, how you are doing it makes sense for now.
roles/pulp3-devel/tasks/main.yml
Outdated
| - dnf-utils | ||
| - dstat | ||
| - fd-find | ||
| - fedora-easy-karma |
There was a problem hiding this comment.
Can we remove this package and some of the others? I don't many of these tools, can we reduce this to the minimum of tools that are used by the aliases for now, and any tools that others want can be an additive change later?
CodeHeeler
force-pushed
the
issue-4234
branch
from
5dcc273
to
e0efdb3
Compare
roles/pulp3-devel/tasks/main.yml
Outdated
| - httpie | ||
| - iotop | ||
| - jnettop | ||
| - jq |
There was a problem hiding this comment.
leave this, its in our docs
roles/pulp3-devel/tasks/main.yml
Outdated
| - fedora-easy-karma | ||
| - fpaste | ||
| - fzf | ||
| - git |
There was a problem hiding this comment.
I think git is already installed
roles/pulp3-devel/tasks/main.yml
Outdated
| - fzf | ||
| - git | ||
| - htop | ||
| - httpie |
There was a problem hiding this comment.
leave this, its in our docs
roles/pulp3-devel/tasks/main.yml
Outdated
| - jq | ||
| - ncdu | ||
| - python-django-bash-completion | ||
| - python-ipdb |
There was a problem hiding this comment.
I use this all the time, but it is not in our docs. For packages in this category, IMO, devs should install on their own. Its really easy to make a personal role and add it to a Vagrantfile or whatever. This way, we don't waste time waiting on the installation of tools that other people sometimes use.
There was a problem hiding this comment.
On second thought, this should be removed. If we install this, it should be pip installed, not dnf.
roles/pulp3-devel/tasks/main.yml
Outdated
| - ncdu | ||
| - python-django-bash-completion | ||
| - python-ipdb | ||
| - python-rpdb |
There was a problem hiding this comment.
on second thought, i think take this out. many on the team use pycharm's remote debugger, and i almost exclusively use ipdb while running processes in the foreground. if this annoys people, they can always add it back.
if this goes, telnet should also go.
roles/pulp3-devel/tasks/main.yml
Outdated
| - redhat-lsb-core | ||
| - ripgrep | ||
| - screen | ||
| - telnet |
There was a problem hiding this comment.
We used to have an alias that used this, but I don't see it "pdebug". This is only necessary if we have rpdb installed. I say,we remove this.
roles/pulp3-devel/tasks/main.yml
Outdated
| - telnet | ||
| - tmux | ||
| - tree | ||
| - wget |
There was a problem hiding this comment.
not in the docs, but please leave it anyway. so basic.
roles/pulp3-devel/tasks/main.yml
Outdated
| - tmux | ||
| - tree | ||
| - wget | ||
| - vim-enhanced |
There was a problem hiding this comment.
+1 leave it in +0 take it out. vi is already installed, and this package can be somewhat slow to install and has caused problems in the past.
There was a problem hiding this comment.
Since the source is mounted into the Vagrant box, everyone can use their own favourite editor (with their systemwide configuration). I'd say we don't need this.
There was a problem hiding this comment.
Reducing to a minimal set of installed packages has been moved to 4322:
https://pulp.plan.io/issues/4322
And I have a PR up here where we can continue this discussion of packages:
#63
roles/pulp3-devel/tasks/main.yml
Outdated
| - python-ipdb | ||
| - python-rpdb | ||
| - python3-setuptools | ||
| - python3-virtualenvwrapper |
There was a problem hiding this comment.
this is used by our "workon pulp" syntax, please leave in.
roles/pulp3-devel/tasks/main.yml
Outdated
| - dstat | ||
| - fd-find | ||
| - fedora-easy-karma | ||
| - fpaste |
There was a problem hiding this comment.
i think lets get rid of this
| } | ||
| _pstatus_help="Report the status of all pulp-related services" | ||
|
|
||
| preset() { |
| pclean() { | ||
| workon pulp | ||
| pulp-manager reset_db --noinput | ||
| pulp-manager migrate auth --noinput |
There was a problem hiding this comment.
this line can be removed now
| } | ||
| _phelp_help="Print this help" | ||
|
|
||
| alias phttp="http" |
There was a problem hiding this comment.
this is a pretty useless alias, given that its longer than the thing it aliases :)
I think it can be changed to http --auth admin:admin which would be more useful, since we set the password. Either remove or change.
There was a problem hiding this comment.
I think, we set the password in .netrc so +1 for removal.
| pulp_source_dir: "/home/vagrant/devel/pulp" | ||
| pulp_plugin_source_dir: "/home/vagrant/devel/pulpcore-plugin" | ||
| pulp_secret_key: "unsafe_default" | ||
| developer_user: "vagrant" | ||
| pulp_create_user: false | ||
| developer_user_home: "/home/vagrant" |
There was a problem hiding this comment.
Since we are starting to get a longish list, could you alphabetize the vars?
| @@ -20,3 +25,4 @@ | |||
| - pulp3-workers | |||
| - pulp3-resource-manager | |||
| - pulp3-webserver | |||
| - pulp3-devel | |||
There was a problem hiding this comment.
Does pulp3-devel work without the previous roles? If not, perhaps we should remove them and put them in the pulp3-devel roles meta dependencies.
CodeHeeler
force-pushed
the
issue-4234
branch
2 times, most recently
from
c7600e1
to
857a3ac
Compare
Switching devel environment to use pulplift first focused on hooking up, now focusing on cleaning up unused changes along the way or unwanted items. Added doc building requirements re #4234 https://pulp.plan.io/issues/4234
CodeHeeler
force-pushed
the
issue-4234
branch
from
857a3ac
to
b8ab4d3
Compare
There was a problem hiding this comment.
I just tested this and it works as expected. Thank you @CodeHeeler for this great contribution!
The suggested changes from @asmacdo are being tracked in https://pulp.plan.io/issues/4322
No description provided.