Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fedora 35 support #797

Merged
merged 1 commit into from Nov 5, 2021
Merged

Add Fedora 35 support #797

merged 1 commit into from Nov 5, 2021

Conversation

fao89
Copy link
Member

@fao89 fao89 commented Nov 3, 2021

[noissue]

@fao89 fao89 marked this pull request as draft November 3, 2021 11:47
@fao89 fao89 marked this pull request as ready for review November 3, 2021 18:57
@fao89 fao89 requested a review from a team November 4, 2021 17:45
@@ -0,0 +1 @@
Fedora-34.yml
Copy link
Member

@mdellweg mdellweg Nov 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a badly disguised symlink?
(I mean in the way represented by github...)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, it is!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought they'd done better in the past.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How am i supposed to see this is not a file containing the name of another file? Right now, here i can only assume the tests would catch this ambiguity.

@fao89 fao89 merged commit e90fa40 into pulp:master Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants