1103311 - Extract any unit_key fields from metadata if None #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -152,7 +153,7 @@ def _extract_non_standard_json(module, filename, temp_dir): | |||
| :raise MissingModuleFile: if the module's metadata file cannot be found | |||
| """ | |||
|
|
|||
| extraction_dir = os.path.join(temp_dir, module.author, module.name, module.version) | |||
| extraction_dir = os.path.join(temp_dir, (filename + EXTRACT_DIRECTORY_SUFFIX)) | |||
There was a problem hiding this comment.
It's better to use the tempfile.mkdtemp module from the standard library to create a temporary directory. That's what this probably should have done to begin with.
|
|
||
| from pulp.server.exceptions import InvalidValue | ||
|
|
||
| from pulp_puppet.common import constants | ||
|
|
||
| from pulp.common.compat import json |
There was a problem hiding this comment.
for pep8, put this right above line 25.
If no unit_key metadata is passed in for uploaded puppet modules, just use the module metadata to populate name, author, and version. https://bugzilla.redhat.com/show_bug.cgi?id=1103311
|
LGTM |
mhrivnak
added a commit
that referenced
this pull request
Jun 5, 2014
1103311 - Extract any unit_key fields from metadata if None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no unit_key metadata is passed in for uploaded puppet modules, just use the
module metadata to populate name, author, and version.
https://bugzilla.redhat.com/show_bug.cgi?id=1103311
TODO