Skip to content

redhat bug 946966, fix versioning for module downloads #64

wants to merge 1 commit into from

2 participants

jdef commented Aug 28, 2013

[root@project2 modules]# puppet module install companyname-project --module_repository
Notice: Preparing to install into /etc/puppet/modules ...
Notice: Downloading from ...
Notice: Installing -- do not interrupt ...
└── companyname-project (v0.0.6-20130827151152)

pulp member
mhrivnak commented Sep 6, 2013

Thank you for the submission! I ended up using the semantic_version python library to accomplish this, which resulted in a very clean and very small diff, and allows us to not be responsible for implementing and maintaining semver compatibility.

That said, looking at your PR definitely helped, and I hope we can find an opportunity in the future to merge some commits from you. :)

@mhrivnak mhrivnak closed this Sep 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.