Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new changelog process #245

Merged
merged 1 commit into from Jun 3, 2019
Merged

Add new changelog process #245

merged 1 commit into from Jun 3, 2019

Conversation

bmbouter
Copy link
Member

@bmbouter bmbouter commented Jun 3, 2019

  • Adds a changelog update section to the docs
  • creates the base CHANGES.rst file
  • creates the CHANGES directory for news updates and indicates to git to
    store the dir even if empty with a .gitignore.
  • adds a release note for this change
  • adds a docs section that loads the CHANGES.rst file on the website
  • Adds a contributing guide
  • mMoves existing release notes to HISTORY.rst

https://pulp.plan.io/issues/4875
re #4875

@pep8speaks
Copy link

pep8speaks commented Jun 3, 2019

Hello @bmbouter! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-06-03 19:39:07 UTC

- Adds a changelog update section to the docs
- creates the base CHANGES.rst file
- creates the CHANGES directory for news updates and indicates to git to
  store the dir even if empty with a .gitignore.
- adds a release note for this change
- adds a docs section that loads the CHANGES.rst file on the website
- Adds a contributing guide
- mMoves existing release notes to HISTORY.rst

https://pulp.plan.io/issues/4875
re #4875
@asmacdo asmacdo merged commit 5ede8ef into pulp:master Jun 3, 2019
Copy link
Contributor

@CodeHeeler CodeHeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and I also have read over the towncrier side when you suggested this on list previously. Thanks for this PR!

@bmbouter bmbouter deleted the add-changelog branch June 3, 2019 20:12
@bmbouter
Copy link
Member Author

bmbouter commented Jun 3, 2019

@asmacdo @CodeHeeler thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants