Adds alternate data format for 'date' in issued #1134
Conversation
The Google updateinfo files use an alternate format for the 'date' data for when an Erratum was issued. See the issue for more details. This also adds a unit test of actual data from Google's repository. https://pulp.plan.io/issues/3820 closes #3820
|
@bmbouter thanks for the patch! Cheers, |
|
@dparalen Yeah that's a good question. This bug was focused only on the sync side, but I see what you're saying. Right now we don't have a feature set to publish data using multiple errata formats so that would be a different piece of work than what the user requested. If users need something like that I hope they file the feature request. How does that sound? |
|
ok test |
3 similar comments
|
ok test |
|
ok test |
|
ok test |
|
@bmbouter fair enough |
| package_info['issued'] = issued_element.attrib['date'] | ||
| except KeyError: | ||
| # If there is a sub-element named 'date' instead of an attribute, use that | ||
| package_info['issued'] = issued_element.find('date').text |
There was a problem hiding this comment.
What happens if date does not exist as a sub-element either? Which exception is it going to bubble up?
There was a problem hiding this comment.
oh that's a good point. It probably needs to raise when there are 0 sub-elements also. A previous version I had did that. @dralley do you agree?
|
This is very strange, but I can't reproduce the issue now. I've commented here closing it as WORKSFORME. https://pulp.plan.io/issues/3820#note-6 |
The Google updateinfo files use an alternate format for the 'date' data
for when an Erratum was issued. See the issue for more details.
This also adds a unit test of actual data from Google's repository.
https://pulp.plan.io/issues/3820
closes #3820