Remove create kwarg since by default it's true #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We discovered an issue where on some versions of python2-solv, there was no create kwarg for str2dir. So we're removing it from this call since by default it's True anyway. Note that this is not really a fix for #3876 https://pulp.plan.io/issues/3876 ref #3876
jortel
approved these changes
Aug 1, 2018
|
ok test |
|
The actual issue has been fixed and we've decided to abandon this change. |
|
Hello @daviddavis! Thanks for updating the PR.
|
|
Re-opening this PR b/c the fix rel-eng did was incorrect, and will cause problems down the road. This will be needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discovered an issue where on some versions of python2-solv, there was
no create kwarg for str2dir. So we're removing it from this call since by
default it's True anyway.
Note that this is not really a fix for #3876
https://pulp.plan.io/issues/3876
ref #3876