Attempt to install yum in Travis #1191
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddavis
force-pushed
the
use-yum
branch
3 times, most recently
from
39d1b8d
to
6cebaf7
Compare
nixocio
reviewed
Sep 20, 2018
| @@ -127,6 +127,7 @@ def gen_yum_config_file(cfg, repositoryid, baseurl, name, **kwargs): | |||
| 'yes' if cfg.get_hosts('api')[0].roles['api'].get('verify') else 'no' | |||
| ) | |||
|
|
|||
| os.system('sudo mkdir -p /etc/yum.repos.d/') | |||
There was a problem hiding this comment.
I think the cli client will be a better fit.
cli_client = cli.Client(self.cfg)
cli_client.run(('mkdir -p /etc/yum.repos.d/'), sudo=True)
dralley
requested changes
Sep 27, 2018
|
@daviddavis Could you rebase this? |
We have a smash test that requires dnf/yum. Attempt to run it by installing the Ubuntu yum package. [noissue]
|
@dralley I rebased but it's still hitting the same failure. I've looked into this error before but googling turns up nil. Any thoughts? |
|
@daviddavis I think this is why. I don't think this is going to work https://askubuntu.com/a/827462 edit: there's also this https://askubuntu.com/questions/161437/when-would-yum-be-of-use-to-an-ubuntu-user/166897#166897 But maybe we shoudln't rely on this being possible |
|
Good find. I agree and therefore am closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a smash test that requires dnf/yum. Attempt to run it by
installing the Ubuntu yum package.