Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upOnly show checksum if it's not blank #1197
Merged
Conversation
fixes #4033 https://pulp.plan.io/issues/4033
|
+1 Thanks, @daviddavis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
daviddavis commentedSep 21, 2018
We could still end up with "Unknown checksum" values but I think that's ok and it should be less likely that checksum is set but sum_type is not.
fixes #4033
https://pulp.plan.io/issues/4033