Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One shot RPM uploader #1246

Merged
merged 1 commit into from Feb 19, 2019
Merged

One shot RPM uploader #1246

merged 1 commit into from Feb 19, 2019

Conversation

pavelpicka
Copy link
Contributor

@pavelpicka pavelpicka commented Dec 17, 2018

RFE to upload one RPM file and optionally create new
version of repository with this added package.

closes: #4087
https://pulp.plan.io/issues/4087

Signed-off-by: Pavel Picka ppicka@redhat.com

@pavelpicka pavelpicka force-pushed the 4087-one-shot-upload branch 5 times, most recently from 946f9d8 to 2def575 Compare December 18, 2018 13:17
@dralley
Copy link
Contributor

dralley commented Dec 20, 2018

I created this issue to track testing this

https://pulp.plan.io/issues/4285


Args:
file@: package to upload
repository: repository to update
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if "repository" were optional. You could upload a bunch of units without making a bunch of repository versions, and then add them in one operation.

@dralley
Copy link
Contributor

dralley commented Feb 4, 2019

@pavelpicka If you get this PR fixed up, I'll review it and we can get it merged in so that hopefully it doesn't get broken again like this.

RFE to upload one RPM file and optionally create new
version of repository with this added package.

closes: #4087
https://pulp.plan.io/issues/4087

Signed-off-by: Pavel Picka <ppicka@redhat.com>
@pavelpicka pavelpicka changed the title One shot RPM uploader [WIP] One shot RPM uploader Feb 14, 2019
@pavelpicka pavelpicka changed the title [WIP] One shot RPM uploader One shot RPM uploader Feb 18, 2019
Copy link
Contributor

@dralley dralley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pavelpicka This works great! I see what you mean about it not showing up properly in the docs though. i'm going to recommend that we try to fix that as a separate issue, because there are other (unrelated) API docs issues with the RPM plugin, namely that many of the viewsets show up with the wrong name. Would you mind filing that issue?

@pavelpicka
Copy link
Contributor Author

@dralley Yes docs are yet to fix but I agree to fix it separately and I will file the issue. Thanks

@dralley dralley merged commit ea4374d into pulp:master Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants