Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish modulemd/productid when generate_sqlite is set to true #1269

Merged
merged 1 commit into from Feb 21, 2019

Conversation

JayZ12138
Copy link

@JayZ12138 JayZ12138 commented Feb 7, 2019

When publish repos, the command createrepo_c could be used but the option
--keep-all-metadata for this command doesn't really keep all metadata --
moudlemd and product_id file will be thrown away.
Now make it keeps these file by running command sqliterepo_c

bug filed by Rohan Mcgovern:
https://bugzilla.redhat.com/show_bug.cgi?id=1670651

@pep8speaks
Copy link

pep8speaks commented Feb 7, 2019

Hello @JayZ12138! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on February 20, 2019 at 15:51 Hours UTC

@pulpbot
Copy link
Member

pulpbot commented Feb 7, 2019

Can one of the admins verify this patch?

1 similar comment
@pulpbot
Copy link
Member

pulpbot commented Feb 7, 2019

Can one of the admins verify this patch?

@JayZ12138
Copy link
Author

any idea why it's failing? worked on our jenkins test

@rohanpm
Copy link

rohanpm commented Feb 11, 2019

@JayZ12138 it fails due to the PEP8 violations, which are also mentioned in the comment from @pep8speaks.

The change has to pass flake8 command.

@pulpbot
Copy link
Member

pulpbot commented Feb 11, 2019

Can one of the admins verify this patch?

@goosemania
Copy link
Member

ok test

@ipanova
Copy link
Member

ipanova commented Feb 12, 2019

@JayZ12138 thank you for the PR. Please open an issue in the upstream tracker https://pulp.plan.io/issues/new and follow these standards for the commit message https://docs.pulpproject.org/en/3.0/nightly/contributing/git.html#commit-message. Let us know if there are any difficulties.

@JayZ12138 JayZ12138 changed the title Publish modulemd/productid when generate_sqlite is set to true [DELIV… Publish modulemd/productid when generate_sqlite is set to true Feb 14, 2019
@JayZ12138
Copy link
Author

created issue and updated commit message

@goosemania
Copy link
Member

ok test

@ipanova
Copy link
Member

ipanova commented Feb 20, 2019

@JayZ12138 please update the command with sqliterepo_c

raise PulpCodedException(error_codes.RPM0001, command='createrepo_c', stdout=stdout,

@ipanova
Copy link
Member

ipanova commented Feb 20, 2019

pleae add a release note that The generation of sqlite files is now done with sqlite repo_c instead of createrepo_c

@ipanova
Copy link
Member

ipanova commented Feb 20, 2019

i have tested with sqliterepo_c and modes.yaml file is preserved.

When publish repos, the command createrepo_c could be used but the option
--keep-all-metadata for this command doesn't really keep all metadata --
moudlemd and product_id file will be thrown away.
Now make it keeps these file by running command sqliterepo_c

ref #4419
https://pulp.plan.io/issues/4419
@ipanova
Copy link
Member

ipanova commented Feb 21, 2019

ok test

@ipanova ipanova merged commit af3b490 into pulp:2-master Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants