Replace remaining usage of createrepo with createrepo_c #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From Fedora 29 onwards, createrepo is Obsoleted by createrepo_c. Having pulp_rpm depend on both createrepo and createrepo_c thus blocks usage or development there. Let's move the last remaining createrepo code over to createrepo_c to resolve this. closes #4492 https://pulp.plan.io/issues/4492
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
ok test |
|
That CI job is failing because python-createrepo_c isn't installed. How do I get it installed to the CI environment? I have a pulp-packaging PR already, https://github.com/pulp/pulp-packaging/pull/85/files |
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
Thank you for opening a PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Fedora 29 onwards, createrepo is Obsoleted by createrepo_c.
Having pulp_rpm depend on both createrepo and createrepo_c
thus blocks usage or development there. Let's move the last
remaining createrepo code over to createrepo_c to resolve this.
closes #4492
https://pulp.plan.io/issues/4492