Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accidental module/package copies in depsolving #1383

Closed
wants to merge 0 commits into from

Conversation

@dralley
Copy link
Contributor

commented Jun 27, 2019

Fix modules being accidentally copied when they contain artifacts that
shadow RPMs in the standard repository that would otherwise be faked by
the depsolver.

closes #4962
https://pulp.plan.io/issues/4962

@dralley

This comment has been minimized.

Copy link
Contributor Author

commented Jun 27, 2019

Currently the only commit here does only refactoring, no bugfix yet. I'll do them both in this PR, if nobody minds.

@dralley dralley force-pushed the dralley:fix-modular-depsolv2 branch 7 times, most recently from 017725b to 8dd0d68 Jun 29, 2019
@pep8speaks

This comment has been minimized.

Copy link

commented Jul 1, 2019

Hello @dralley! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-07-01 20:15:55 UTC
@dralley dralley force-pushed the dralley:fix-modular-depsolv2 branch from 8dd0d68 to 5dce8d0 Jul 1, 2019
@dralley dralley closed this Jul 3, 2019
@dralley dralley force-pushed the dralley:fix-modular-depsolv2 branch from 5dce8d0 to bf6170b Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.