New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kickstart Models #1418

Merged

bmbouter merged 1 commit into pulp:master from fao89:5201-distribution-tree-model

Sep 2, 2019

Member

fao89 commented Aug 19, 2019

Kickstarts
Create the model(s) for distribution trees
closes #5201

daviddavis added the Work In Progress label

bmbouter reviewed

View reviewed changes

pulp_rpm/app/models.py Outdated Show resolved Hide resolved

goosemania reviewed

View reviewed changes

pulp_rpm/app/models.py Outdated Show resolved Hide resolved

fao89 force-pushed the 5201-distribution-tree-model branch 6 times, most recently from 8e52848 to 9cd3ad5 Compare

August 20, 2019 16:12

daviddavis reviewed

View reviewed changes

pulp_rpm/app/models.py Outdated Show resolved Hide resolved

daviddavis reviewed

View reviewed changes

pulp_rpm/app/models.py Outdated Show resolved Hide resolved

daviddavis reviewed

View reviewed changes

pulp_rpm/app/models.py Outdated Show resolved Hide resolved

daviddavis reviewed

View reviewed changes

pulp_rpm/app/models.py Outdated Show resolved Hide resolved

fao89 force-pushed the 5201-distribution-tree-model branch from 9cd3ad5 to a80cefe Compare

August 20, 2019 20:51

fao89 changed the title ~~WIP - Create the model(s) for distribution trees~~ Create the model(s) for distribution trees

fao89 force-pushed the 5201-distribution-tree-model branch from a80cefe to b81e740 Compare

August 21, 2019 13:51

fao89 requested a review from a team

August 21, 2019 22:02

pep8speaks commented Aug 21, 2019 •

edited

Hello @fabricio-aguiar! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-09-02 16:45:58 UTC

fao89 force-pushed the 5201-distribution-tree-model branch 3 times, most recently from 3c2068b to d38f0fc Compare

August 22, 2019 22:12

nixocio reviewed

View reviewed changes

pulp_rpm/tests/functional/api/test_sync.py Outdated

+                      self.assertIsNone(repo['_latest_version_href'])
+                      sync(self.cfg, remote, repo)
+                      repo = self.client.get(repo['_href'])
+                      import pdb; pdb.set_trace()

nixocio Aug 23, 2019

Suggested change

import pdb; pdb.set_trace()

Member Author

fao89 Aug 23, 2019

It still on development, and at the end of the day I push everything as is, just to send on scrum status

nixocio reviewed

View reviewed changes

pulp_rpm/tests/functional/api/test_sync.py Outdated

@@ @@ -100,6 +101,65 @@ def test_rpm(self): @@
                       )
                       self.assertDictEqual(get_added_content_summary(repo), {})
+                  def test_rpm_kickstart(self):
+                      """Sync repositories with the rpm plugin.

nixocio Aug 23, 2019

It would be nice to update docstring with the related issue.

        This test targets the following issue:


        `Pulp #5201 <https://pulp.plan.io/issues/5201>`_

fao89 changed the title ~~Create the model(s) for distribution trees~~ WIP - Create the model(s) for distribution trees

fao89 force-pushed the 5201-distribution-tree-model branch from d38f0fc to 6c1fb1e Compare

August 23, 2019 18:20

bmbouter reviewed

View reviewed changes

pulp_rpm/app/tasks/synchronizing.py Outdated Show resolved Hide resolved

bmbouter reviewed

View reviewed changes

pulp_rpm/app/tasks/synchronizing.py Outdated Show resolved Hide resolved

bmbouter reviewed

View reviewed changes

pulp_rpm/app/tasks/synchronizing.py Outdated Show resolved Hide resolved

bmbouter reviewed

View reviewed changes

pulp_rpm/app/tasks/synchronizing.py Outdated Show resolved Hide resolved

bmbouter reviewed

View reviewed changes

pulp_rpm/app/tasks/utils.py Outdated Show resolved Hide resolved

fao89 added a commit to fao89/pulp_rpm that referenced this pull request


          kickstart syncing

b728f6f

closes #5202
https://pulp.plan.io/issues/5202
Required PR: pulp#1418

bmbouter removed the Work In Progress label

bmbouter reviewed

View reviewed changes

pulp_rpm/app/models.py Outdated

+                      DistributionTree, on_delete=models.CASCADE, related_name='addons'
+                  )
+                  repository = models.ForeignKey(
+                      Repository, on_delete=models.CASCADE, related_name='addons'

Member

bmbouter Sep 2, 2019

I think this needs to be on_delete=models.PROTECT because we can't allow the user to delete a repo that is still backing DistributionTree units in Pulp. Does this make sense?

bmbouter reviewed

View reviewed changes

pulp_rpm/app/models.py Outdated

+                      DistributionTree, on_delete=models.CASCADE, related_name='variants'
+                  )
+                  repository = models.ForeignKey(
+                      Repository, on_delete=models.CASCADE, related_name='+'

Member

bmbouter Sep 2, 2019

Similar here with the PROTECT. @fabricio-aguiar what do you think?


          Kickstart models

d9591bd

closes #5201
https://pulp.plan.io/issues/5201

fao89 force-pushed the 5201-distribution-tree-model branch from 3eeba0f to d9591bd Compare

September 2, 2019 16:45

bmbouter approved these changes

View reviewed changes

Member

bmbouter left a comment

@fabricio-aguiar Thank you so much for making this. After your last round of fixes this looks good to me. 👍

bmbouter merged commit 380d4c8 into pulp:master

fao89 added a commit to fao89/pulp_rpm that referenced this pull request


          kickstart syncing

2c28bd7

closes #5202
https://pulp.plan.io/issues/5202
Required PR: pulp#1418

fao89 added a commit to fao89/pulp_rpm that referenced this pull request


          kickstart syncing

6770f96

closes #5202
https://pulp.plan.io/issues/5202
Required PR: pulp#1418

fao89 added a commit to fao89/pulp_rpm that referenced this pull request


          kickstart syncing

87ddb1c

closes #5202
https://pulp.plan.io/issues/5202
Required PR: pulp#1418

fao89 added a commit to fao89/pulp_rpm that referenced this pull request


          publishing kickstarts

c1794d2

closes #5206
https://pulp.plan.io/issues/5206
Required PR: pulp#1418
Required PR: pulp#1427

fao89 added a commit to fao89/pulp_rpm that referenced this pull request


          publishing kickstarts

835ee9b

closes #5206
https://pulp.plan.io/issues/5206
Required PR: pulp#1418
Required PR: pulp#1427

fao89 added a commit to fao89/pulp_rpm that referenced this pull request


          kickstart syncing

bb127db

closes #5202
https://pulp.plan.io/issues/5202
Required PR: pulp#1418

fao89 added a commit to fao89/pulp_rpm that referenced this pull request


          kickstart syncing

e04b270

closes #5202
https://pulp.plan.io/issues/5202
Required PR: pulp#1418

fao89 added a commit to fao89/pulp_rpm that referenced this pull request


          kickstart syncing

3bd69bf

closes #5202
https://pulp.plan.io/issues/5202
Required PR: pulp#1418

fao89 added a commit to fao89/pulp_rpm that referenced this pull request


          kickstart syncing

519e1e4

closes #5202
https://pulp.plan.io/issues/5202
Required PR: pulp#1418

fao89 added a commit to fao89/pulp_rpm that referenced this pull request


          kickstart syncing

21bcc10

closes #5202
https://pulp.plan.io/issues/5202
Required PR: pulp#1418

fao89 added a commit to fao89/pulp_rpm that referenced this pull request


          kickstart syncing

0057cab

closes #5202
https://pulp.plan.io/issues/5202
Required PR: pulp#1418

fao89 added a commit to fao89/pulp_rpm that referenced this pull request


          publishing kickstarts

57614db

closes #5206
https://pulp.plan.io/issues/5206
Required PR: pulp#1418
Required PR: pulp#1427

fao89 added a commit to fao89/pulp_rpm that referenced this pull request


          publishing kickstarts

ee6a358

closes #5206
https://pulp.plan.io/issues/5206
Required PR: pulp#1418
Required PR: pulp#1427

fao89 added a commit to fao89/pulp_rpm that referenced this pull request


          publishing kickstarts

44a0bcd

closes #5206
https://pulp.plan.io/issues/5206
Required PR: pulp#1418
Required PR: pulp#1427

fao89 added a commit to fao89/pulp_rpm that referenced this pull request


          publishing kickstarts

f7fcead

closes #5206
https://pulp.plan.io/issues/5206
Required PR: pulp#1418
Required PR: pulp#1427

fao89 added a commit to fao89/pulp_rpm that referenced this pull request


          publishing kickstarts

15923a3

closes #5206
https://pulp.plan.io/issues/5206
Required PR: pulp#1418
Required PR: pulp#1427

fao89 added a commit to fao89/pulp_rpm that referenced this pull request


          publishing kickstarts

54388f7

closes #5206
https://pulp.plan.io/issues/5206
Required PR: pulp#1418
Required PR: pulp#1427
Required PR: pulp#1440

fao89 added a commit to fao89/pulp_rpm that referenced this pull request


          publishing kickstarts

24c1d95

closes #5206
https://pulp.plan.io/issues/5206
Required PR: pulp#1418
Required PR: pulp#1427
Required PR: pulp#1440

fao89 added a commit to fao89/pulp_rpm that referenced this pull request


          publishing kickstarts

8a32f22

closes #5206
https://pulp.plan.io/issues/5206
Required PR: pulp#1418
Required PR: pulp#1427
Required PR: pulp#1440

fao89 added a commit to fao89/pulp_rpm that referenced this pull request


          publishing kickstarts

273c4eb

closes #5206
https://pulp.plan.io/issues/5206
Required PR: pulp#1418
Required PR: pulp#1427
Required PR: pulp#1440

fao89 added a commit to fao89/pulp_rpm that referenced this pull request


          publishing kickstarts

f4e5d2f

closes #5206
https://pulp.plan.io/issues/5206
Required PR: pulp#1418
Required PR: pulp#1427
Required PR: pulp#1440

fao89 added a commit to fao89/pulp_rpm that referenced this pull request


          publishing kickstarts

8a8048e

closes #5206
https://pulp.plan.io/issues/5206
Required PR: pulp#1418
Required PR: pulp#1427
Required PR: pulp#1440

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment