Add models for content types from comps.xml #1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @CodeHeeler! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-08-27 12:33:54 UTC |
CodeHeeler
changed the title
CodeHeeler
force-pushed
the
issue-5097
branch
2 times, most recently
from
66b5cc9
to
a74ef43
Compare
CodeHeeler
changed the title
CodeHeeler
changed the title
goosemania
requested changes
Aug 23, 2019
There was a problem hiding this comment.
@CodeHeeler , thanks! It looks good. The only missing part is migrations.
We committed migrations in pulp_rpm, so every time there is any model change, we need to generate them (with django-admin makemigrations rpm) and commit them.
Please, wait until this #1417 is merged, then you can rebase and generate and commit migrations.
Adds Group, Category, Environment, and Langpacks content types models fixes #5331 https://pulp.plan.io/issues/5331
goosemania
approved these changes
Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds models for Group, Category, Environment, and Langpacks content types
fixes #5331
https://pulp.plan.io/issues/5331