Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync modulemd and modulemd-defaults #1434

Merged
merged 1 commit into from Sep 20, 2019

Conversation

pavelpicka
Copy link
Contributor

@pavelpicka pavelpicka commented Sep 5, 2019

Add sync support for modulemd and modulemd-defaults and create relations between modulemd and RPM packages.
And keep snippet from modules.yaml as an artifact for content (modulemd and modulemd-defaults).

Required PR: pulp/pulpcore-plugin#130

re #5172
https://pulp.plan.io/issues/5172

@pep8speaks
Copy link

pep8speaks commented Sep 5, 2019

Hello @pavelpicka! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-09-20 10:43:45 UTC

@pavelpicka pavelpicka force-pushed the 5172-modular-sync branch 7 times, most recently from 4a4b3af to d335a26 Compare September 5, 2019 14:19
pavelpicka added a commit to pavelpicka/pulpcore-plugin that referenced this pull request Sep 5, 2019
adds conditional to skip artifactdownload and artifactremote stages if not needed for declared artifatc if not needed

Required PR: pulp/pulp_rpm#1434

re #5172
https://pulp.plan.io/issues/5172
pavelpicka added a commit to pavelpicka/pulpcore-plugin that referenced this pull request Sep 5, 2019
adds conditional to skip artifactdownload and artifactremote stages if not needed for declared artifact

Required PR: pulp/pulp_rpm#1434

re #5172
https://pulp.plan.io/issues/5172
pavelpicka added a commit to pavelpicka/pulpcore-plugin that referenced this pull request Sep 10, 2019
adds conditional to skip artifactdownload and artifactremote stages if not needed for declared artifact by checking if declarative artifact has remote

Required PR: pulp/pulp_rpm#1434

re #5172
https://pulp.plan.io/issues/5172
@pavelpicka pavelpicka force-pushed the 5172-modular-sync branch 2 times, most recently from c432b71 to 38369dc Compare September 10, 2019 14:54
pavelpicka added a commit to pavelpicka/pulpcore-plugin that referenced this pull request Sep 10, 2019
adds conditional to skip artifactdownload and artifactremote stages if not needed for declared artifact by checking if declarative artifact has remote

Required PR: pulp/pulp_rpm#1434

re #5172
https://pulp.plan.io/issues/5172
pavelpicka added a commit to pavelpicka/pulpcore-plugin that referenced this pull request Sep 11, 2019
adds conditional to skip artifactdownload and artifactremote stages if not needed for declared artifact by checking if declarative artifact has remote

Required PR: pulp/pulp_rpm#1434

re #5172
https://pulp.plan.io/issues/5172
pavelpicka added a commit to pavelpicka/pulpcore-plugin that referenced this pull request Sep 11, 2019
adds conditional to skip artifactdownload and artifactremote stages if not needed for declared artifact by checking if declarative artifact has remote

Required PR: pulp/pulp_rpm#1434

re #5172
https://pulp.plan.io/issues/5172
pavelpicka added a commit to pavelpicka/pulpcore-plugin that referenced this pull request Sep 11, 2019
adds conditional to skip artifactdownload and artifactremote stages if not needed for declared artifact by checking if declarative artifact has remote

Required PR: pulp/pulp_rpm#1434

re #5172
https://pulp.plan.io/issues/5172
@pavelpicka pavelpicka force-pushed the 5172-modular-sync branch 5 times, most recently from 7ca243f to bbab7fb Compare September 16, 2019 08:27
pulp_rpm/app/modulemd.py Outdated Show resolved Hide resolved
pulp_rpm/app/modulemd.py Outdated Show resolved Hide resolved
pulp_rpm/app/tasks/synchronizing.py Outdated Show resolved Hide resolved
pulp_rpm/app/tasks/synchronizing.py Show resolved Hide resolved
pulp_rpm/app/tasks/synchronizing.py Outdated Show resolved Hide resolved
pulp_rpm/app/tasks/synchronizing.py Outdated Show resolved Hide resolved
pulp_rpm/app/tasks/synchronizing.py Outdated Show resolved Hide resolved
pulp_rpm/app/viewsets.py Outdated Show resolved Hide resolved
pulp_rpm/app/viewsets.py Outdated Show resolved Hide resolved
pulp_rpm/app/tasks/synchronizing.py Outdated Show resolved Hide resolved
@pavelpicka pavelpicka force-pushed the 5172-modular-sync branch 3 times, most recently from afce0b3 to b372c78 Compare September 17, 2019 12:58
@pavelpicka pavelpicka force-pushed the 5172-modular-sync branch 2 times, most recently from 13fa566 to 1892efd Compare September 17, 2019 15:02
Copy link
Member

@goosemania goosemania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more comments left. Most of them we discussed. I think we are very close to merge it.

pulp_rpm/app/modulemd.py Outdated Show resolved Hide resolved
pulp_rpm/app/modulemd.py Outdated Show resolved Hide resolved
pulp_rpm/app/modulemd.py Outdated Show resolved Hide resolved
pulp_rpm/app/modulemd.py Outdated Show resolved Hide resolved
pulp_rpm/app/modulemd.py Show resolved Hide resolved
pulp_rpm/app/tasks/synchronizing.py Outdated Show resolved Hide resolved
pulp_rpm/app/tasks/synchronizing.py Outdated Show resolved Hide resolved
pulp_rpm/app/tasks/synchronizing.py Show resolved Hide resolved
pulp_rpm/app/tasks/synchronizing.py Outdated Show resolved Hide resolved
pulp_rpm/app/tasks/synchronizing.py Outdated Show resolved Hide resolved
pulp_rpm/app/modulemd.py Outdated Show resolved Hide resolved
pulp_rpm/app/modulemd.py Outdated Show resolved Hide resolved
pulp_rpm/app/modulemd.py Outdated Show resolved Hide resolved
pulp_rpm/app/modulemd.py Outdated Show resolved Hide resolved
pulp_rpm/app/tasks/synchronizing.py Outdated Show resolved Hide resolved
pulp_rpm/app/tasks/synchronizing.py Show resolved Hide resolved
pulp_rpm/app/tasks/synchronizing.py Show resolved Hide resolved
pulp_rpm/app/modulemd.py Outdated Show resolved Hide resolved
pulp_rpm/app/tasks/synchronizing.py Outdated Show resolved Hide resolved
@pavelpicka pavelpicka force-pushed the 5172-modular-sync branch 2 times, most recently from e3c96b2 to 62d61f5 Compare September 20, 2019 10:37
Add sync support for modulemd and modulemd-defaults and create relations between modulemd and RPM packages.
And keep snippet from modules.yaml as an artifact for content (modulemd and modulemd-defaults).

closes #5172
https://pulp.plan.io/issues/5172
@goosemania goosemania merged commit f40e01c into pulp:master Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants