New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync modulemd and modulemd-defaults #1434
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @pavelpicka! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-09-20 10:43:45 UTC |
4a4b3af
to
d335a26
Compare
pavelpicka
added a commit
to pavelpicka/pulpcore-plugin
that referenced
this pull request
Sep 5, 2019
adds conditional to skip artifactdownload and artifactremote stages if not needed for declared artifatc if not needed Required PR: pulp/pulp_rpm#1434 re #5172 https://pulp.plan.io/issues/5172
pavelpicka
added a commit
to pavelpicka/pulpcore-plugin
that referenced
this pull request
Sep 5, 2019
adds conditional to skip artifactdownload and artifactremote stages if not needed for declared artifact Required PR: pulp/pulp_rpm#1434 re #5172 https://pulp.plan.io/issues/5172
d335a26
to
8a43376
Compare
pavelpicka
added a commit
to pavelpicka/pulpcore-plugin
that referenced
this pull request
Sep 10, 2019
adds conditional to skip artifactdownload and artifactremote stages if not needed for declared artifact by checking if declarative artifact has remote Required PR: pulp/pulp_rpm#1434 re #5172 https://pulp.plan.io/issues/5172
c432b71
to
38369dc
Compare
pavelpicka
added a commit
to pavelpicka/pulpcore-plugin
that referenced
this pull request
Sep 10, 2019
adds conditional to skip artifactdownload and artifactremote stages if not needed for declared artifact by checking if declarative artifact has remote Required PR: pulp/pulp_rpm#1434 re #5172 https://pulp.plan.io/issues/5172
pavelpicka
added a commit
to pavelpicka/pulpcore-plugin
that referenced
this pull request
Sep 11, 2019
adds conditional to skip artifactdownload and artifactremote stages if not needed for declared artifact by checking if declarative artifact has remote Required PR: pulp/pulp_rpm#1434 re #5172 https://pulp.plan.io/issues/5172
pavelpicka
added a commit
to pavelpicka/pulpcore-plugin
that referenced
this pull request
Sep 11, 2019
adds conditional to skip artifactdownload and artifactremote stages if not needed for declared artifact by checking if declarative artifact has remote Required PR: pulp/pulp_rpm#1434 re #5172 https://pulp.plan.io/issues/5172
38369dc
to
6814ff2
Compare
pavelpicka
added a commit
to pavelpicka/pulpcore-plugin
that referenced
this pull request
Sep 11, 2019
adds conditional to skip artifactdownload and artifactremote stages if not needed for declared artifact by checking if declarative artifact has remote Required PR: pulp/pulp_rpm#1434 re #5172 https://pulp.plan.io/issues/5172
7ca243f
to
bbab7fb
Compare
goosemania
requested changes
Sep 16, 2019
afce0b3
to
b372c78
Compare
13fa566
to
1892efd
Compare
goosemania
requested changes
Sep 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few more comments left. Most of them we discussed. I think we are very close to merge it.
goosemania
requested changes
Sep 19, 2019
goosemania
reviewed
Sep 20, 2019
e3c96b2
to
62d61f5
Compare
Add sync support for modulemd and modulemd-defaults and create relations between modulemd and RPM packages. And keep snippet from modules.yaml as an artifact for content (modulemd and modulemd-defaults). closes #5172 https://pulp.plan.io/issues/5172
62d61f5
to
559f80a
Compare
goosemania
approved these changes
Sep 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sync support for modulemd and modulemd-defaults and create relations between modulemd and RPM packages.
And keep snippet from modules.yaml as an artifact for content (modulemd and modulemd-defaults).
Required PR: pulp/pulpcore-plugin#130
re #5172
https://pulp.plan.io/issues/5172