Renaming base fields #1466
Merged
Renaming base fields #1466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goosemania
reviewed
Oct 4, 2019
CHANGES/5457.feature
Outdated
| @@ -0,0 +1 @@ | |||
| Change `_id`, `_created`, `_last_updated`, `_href` to `pulp_id`, `pulp_created`, `pulp_last_updated`, `pulp_href` | |||
There was a problem hiding this comment.
I think it's probably .removal and not .feature because we are changing api and it's a backward incompatible change
fao89
force-pushed
the
5457
branch
4 times, most recently
from
d0b69a9
to
4ac5928
Compare
_id to pulp_id _created to pulp_created _last_updated to pulp_last_updated _href to pulp_href ref #5457 https://pulp.plan.io/issues/5457 Required PR: pulp/pulpcore#317 Required PR: pulp/pulpcore-plugin#137 Required PR: pulp/pulp-smash#1220
goosemania
approved these changes
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_id to pulp_id
_created to pulp_created
_last_updated to pulp_last_updated
_href to pulp_href
ref #5457
https://pulp.plan.io/issues/5457
Required PR: pulp/pulpcore#317
Required PR: pulp/pulpcore-plugin#137
Required PR: pulp/pulp-smash#1220