WIP - Improve memory performance on syncing #1547
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dralley
reviewed
Dec 3, 2019
pulp_rpm/app/tasks/synchronizing.py
Outdated
| ModulemdPackages = Modulemd.packages.through | ||
| PackageGroup_packages = PackageGroup.related_packages.through | ||
| PackageCategory_groups = PackageCategory.packagegroups.through | ||
| PackageEnvironment_groups = PackageEnvironment.packagegroups.through | ||
| PackageEnvironment_optionalgroups = PackageEnvironment.optionalgroups.through | ||
|
|
||
| update_collection_to_save = MaxSizeBulk(UpdateCollection, 100) |
There was a problem hiding this comment.
bulk_create() has a batch size argument, is there a reason we cannot use that? https://docs.djangoproject.com/en/dev/ref/models/querysets/#bulk-create
There was a problem hiding this comment.
Yesterday @dkliban said he was suspicious that memory was crashing before hitting the saving point, so I built this object to bulk create as soon it reaches the max_length, so it does not need to wait till the end of the for loop.
fao89
commented
Dec 3, 2019
Comment on lines
-768
to
-769
| update_collection.save() | ||
| update_record.collections.add(update_collection) |
There was a problem hiding this comment.
As @dkliban pointed, these lines were consuming some considerable amount of memory, so I changed to bulk creation.
good improvement in memory consumption
https://pulp.plan.io/issues/5688 Required PR: pulp/pulpcore#432 closes #5688
|
Closing in favor of: #1550 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://pulp.plan.io/issues/5688
Required PR: pulp/pulpcore#432
closes #5688