Improve memory performance on syncing #1550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fao89
force-pushed
the
5688_
branch
2 times, most recently
from
2c4bea7
to
9aa7509
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
fao89
force-pushed
the
5688_
branch
3 times, most recently
from
7a95c01
to
b7a1466
Compare
goosemania
reviewed
Dec 9, 2019
| if update_collection_to_save: | ||
| UpdateCollection.objects.bulk_create(update_collection_to_save) | ||
|
|
||
| if update_record_collections_to_save: |
There was a problem hiding this comment.
Naming is somewhat confusing and I don't have any better suggestions. Can you leave a comment that we are saving UpdateRecord -> UpdateCollection relations here? Or do you have any other ideas to clarify it?
pulp_rpm/app/tasks/synchronizing.py
Outdated
Comment on lines
730
to
735
| UpdateRecordCollections = UpdateRecord.collections.through | ||
| ModulemdPackages = Modulemd.packages.through | ||
| PackageGroup_packages = PackageGroup.related_packages.through | ||
| PackageCategory_groups = PackageCategory.packagegroups.through | ||
| PackageEnvironment_groups = PackageEnvironment.packagegroups.through | ||
| PackageEnvironment_optionalgroups = PackageEnvironment.optionalgroups.through |
There was a problem hiding this comment.
I think we are inconsistent here with the naming. Some relations are named using camel case only, some are combination camel and snake ones. Do you think it's worth making it consistent?
goosemania
approved these changes
Dec 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://pulp.plan.io/issues/5688
Required PR: pulp/pulpcore#440
closes #5688