Improve performance by cutting way down on ProgressReport updating #1552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dralley
force-pushed
the
performance
branch
3 times, most recently
from
38fa2b7
to
86d4023
Compare
dralley
commented
Dec 9, 2019
pulp_rpm/app/tasks/synchronizing.py
Outdated
| for batch in grouper(updates, 250): | ||
| advisories_pb.increase_by(len(batch)) | ||
|
|
||
| for update in batch: |
There was a problem hiding this comment.
Hard to tell from the diff but the only change is the above 3 lines and the removal of .increment() below
dralley
commented
Dec 9, 2019
pulp_rpm/app/tasks/synchronizing.py
Outdated
| for batch in grouper(list(packages.values()), 250): | ||
| packages_pb.increase_by(len(batch)) | ||
|
|
||
| for pkg in batch: |
There was a problem hiding this comment.
Hard to tell from the diff but the only change is these 3 lines and the removal of .increment() below
There was a problem hiding this comment.
I took a time measurement of the total time spent in this loop before changing anything, and measured that it took about 30 seconds with 10,500 packages. So 250 packages should represent about 1 update per second, roughly (on my machine).
dralley
force-pushed
the
performance
branch
3 times, most recently
from
6e242f6
to
41f06af
Compare
bmbouter
approved these changes
Dec 9, 2019
There was a problem hiding this comment.
I read through this and it looks good to me. It would maybe be good to have an ack from @goosemania or another RPM team member too perhaps.
Use auto-throttling behavior of ProgressReport context manager. [noissue]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update ProgressReport for batches of content instead of individually.
ProgressReport updating took 30% of the runtime of syncs, now 1%.
Required PR: pulp/pulpcore#441
[noissue]