Adding some not equal filters #1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddavis
force-pushed
the
issue5854
branch
from
164a7fd
to
9ca7fdc
Compare
|
This depends on a pulpcore commit which will not be in pulpcore 3.0 so this change cannot be cherry-picked into pulp_rpm 3.0. |
goosemania
approved these changes
Dec 11, 2019
daviddavis
force-pushed
the
issue5854
branch
from
9ca7fdc
to
282978f
Compare
mdellweg
reviewed
Jan 29, 2020
pulp_rpm/app/viewsets.py
Outdated
| 'status': ['exact', 'in'], | ||
| 'severity': ['exact', 'in'], | ||
| 'type': ['exact', 'in'], | ||
| 'id': ['exact', 'in', 'ne'], |
There was a problem hiding this comment.
Random rant: I am not convinced, you should ever do a ne lookup on id...
Second thought: A 'not in' like filter could be interesting for 'status' and 'severity'.
CodeHeeler
approved these changes
Feb 6, 2020
fixes #5854 Required PR: pulp/pulpcore#452
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5854
Required PR: pulp/pulpcore#452