-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repository mirror #1568
Merged
Merged
Repository mirror #1568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
087db0c
to
91e976d
Compare
91e976d
to
5a117aa
Compare
when reach advisories with same ID in previous repository version reaching a bug addressed here https://pulp.plan.io/issues/5924 |
CodeHeeler
approved these changes
Jan 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pavelpicka
added a commit
to pavelpicka/pulp_rpm
that referenced
this pull request
Jan 21, 2020
Advisory conflict resolution now check current version first if advisory resolution is needed. Enabled SyncMutatedUpdateRecordTestCase for this case. Required PR: pulp#1568 closes: #5924 https://pulp.plan.io/issues/5924
pavelpicka
added a commit
to pavelpicka/pulp_rpm
that referenced
this pull request
Jan 21, 2020
Advisory conflict resolution now check current version first if advisory resolution is needed. Enabled SyncMutatedUpdateRecordTestCase for this case. Required PR: pulp#1568 closes: #5924 https://pulp.plan.io/issues/5924
pavelpicka
added a commit
to pavelpicka/pulp_rpm
that referenced
this pull request
Jan 21, 2020
Advisory conflict resolution now check current version first if advisory resolution is needed. Required PR: pulp#1568 closes: #5924 https://pulp.plan.io/issues/5924
looks good, please rebase |
pavelpicka
added a commit
to pavelpicka/pulp_rpm
that referenced
this pull request
Feb 11, 2020
Advisory conflict resolution now check current version first if advisory resolution is needed. Required PR: pulp#1568 closes: #5924 https://pulp.plan.io/issues/5924
5a117aa
to
7e89e31
Compare
User can 'mirror' a repository. re #5738 https://pulp.plan.io/issues/5738
7e89e31
to
9713b41
Compare
pavelpicka
added a commit
to pavelpicka/pulp_rpm
that referenced
this pull request
Feb 11, 2020
Advisory conflict resolution now check current version first if advisory resolution is needed. Required PR: pulp#1568 closes: #5924 https://pulp.plan.io/issues/5924
goosemania
approved these changes
Feb 11, 2020
pavelpicka
pushed a commit
to pavelpicka/pulp_rpm
that referenced
this pull request
Feb 12, 2020
Repository mirror closes: #6033 https://pulp.plan.io/issues/6033
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User can 'mirror' a repository.
Can fail when sync advisories with same ID. Need to fix 'resolve_advisory' in case of 'mirror' to not check previous version of repository.
re #5738
https://pulp.plan.io/issues/5738