Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository mirror #1568

Merged
merged 1 commit into from
Feb 11, 2020
Merged

Repository mirror #1568

merged 1 commit into from
Feb 11, 2020

Conversation

pavelpicka
Copy link
Contributor

User can 'mirror' a repository.

Can fail when sync advisories with same ID. Need to fix 'resolve_advisory' in case of 'mirror' to not check previous version of repository.

re #5738
https://pulp.plan.io/issues/5738

@pavelpicka pavelpicka changed the title [WIP] Repository mirror Repository mirror Jan 15, 2020
@pavelpicka
Copy link
Contributor Author

pavelpicka commented Jan 15, 2020

when reach advisories with same ID in previous repository version reaching a bug addressed here https://pulp.plan.io/issues/5924

Copy link
Contributor

@CodeHeeler CodeHeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this pull request Jan 21, 2020
Advisory conflict resolution now check current version first if advisory
resolution is needed.
Enabled SyncMutatedUpdateRecordTestCase for this case.

Required PR: pulp#1568

closes: #5924
https://pulp.plan.io/issues/5924
pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this pull request Jan 21, 2020
Advisory conflict resolution now check current version first if advisory
resolution is needed.
Enabled SyncMutatedUpdateRecordTestCase for this case.

Required PR: pulp#1568

closes: #5924
https://pulp.plan.io/issues/5924
pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this pull request Jan 21, 2020
Advisory conflict resolution now check current version first if advisory
resolution is needed.

Required PR: pulp#1568

closes: #5924
https://pulp.plan.io/issues/5924
@goosemania
Copy link
Member

looks good, please rebase

pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this pull request Feb 11, 2020
Advisory conflict resolution now check current version first if advisory
resolution is needed.

Required PR: pulp#1568

closes: #5924
https://pulp.plan.io/issues/5924
User can 'mirror' a repository.

re #5738
https://pulp.plan.io/issues/5738
pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this pull request Feb 11, 2020
Advisory conflict resolution now check current version first if advisory
resolution is needed.

Required PR: pulp#1568

closes: #5924
https://pulp.plan.io/issues/5924
@goosemania goosemania merged commit 60eb63e into pulp:master Feb 11, 2020
pavelpicka pushed a commit to pavelpicka/pulp_rpm that referenced this pull request Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants