Set is_modular flag correctly if there is a module with no artifacts … #1579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in a repo Checking if a quesryset is empty because: Empty queryset Q() combined with __raw__ query makes only the __raw_part applied (the root cause of the bug). Non-empty queryset combined with __raw__ evaluates as AND expression, so both are applied (expected). closes #5942 https://pulp.plan.io/issues/5942
ipanova
reviewed
Jan 9, 2020
| :param modulemd: module for which artifacts should be updated | ||
| :type modulemd: pulp_rpm.plugins.db.models.Modulemd | ||
| """ | ||
| delta = {'is_modular': True} |
There was a problem hiding this comment.
you can use the 'FIELD" variable here
ipanova
approved these changes
Jan 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…in a repo
Checking if a quesryset is empty because:
Empty queryset
Q()combined with__raw__query makes only the__raw__part applied (the root cause of the bug).Non-empty queryset combined with
__raw__evaluates as AND expression, so both are applied (expected).closes #5942
https://pulp.plan.io/issues/5942