Advisory package sum_type #1667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @pavelpicka! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-04-17 22:36:44 UTC |
pavelpicka
force-pushed
the
6442-advisory-sum-type
branch
from
debb356
to
c508877
Compare
|
Attached issue: https://pulp.plan.io/issues/6442 |
dralley
reviewed
Apr 6, 2020
dralley
reviewed
Apr 6, 2020
pavelpicka
force-pushed
the
6442-advisory-sum-type
branch
2 times, most recently
from
cfad9be
to
a802b8f
Compare
|
@dralley updated without backward search of dict |
pavelpicka
force-pushed
the
6442-advisory-sum-type
branch
from
a802b8f
to
cbee293
Compare
dralley
reviewed
Apr 16, 2020
dralley
reviewed
Apr 16, 2020
dralley
reviewed
Apr 16, 2020
|
@goosemania had some other ideas about what to change that might be simpler, FYI @pavelpicka |
goosemania
reviewed
Apr 17, 2020
goosemania
reviewed
Apr 17, 2020
goosemania
reviewed
Apr 17, 2020
goosemania
reviewed
Apr 17, 2020
goosemania
reviewed
Apr 17, 2020
goosemania
reviewed
Apr 17, 2020
pavelpicka
force-pushed
the
6442-advisory-sum-type
branch
from
cbee293
to
9879120
Compare
pavelpicka
force-pushed
the
6442-advisory-sum-type
branch
2 times, most recently
from
b8c42dd
to
047ee65
Compare
dralley
reviewed
Apr 17, 2020
pavelpicka
force-pushed
the
6442-advisory-sum-type
branch
2 times, most recently
from
50be24e
to
9ff26a1
Compare
Advisory package sum_type will be stored as INT as createrepo_c uses it. Upload will translate supported checksum from str to int. User will still see a string representation of sum_type. closes #6442 https://pulp.plan.io/issues/6442
pavelpicka
force-pushed
the
6442-advisory-sum-type
branch
from
9ff26a1
to
73c7dc0
Compare
dralley
approved these changes
Apr 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Advisory package sum_type will be stored as INT as createrepo_c uses it.
Upload will translate supported checksum from str to int.
User will still see a string representation of sum_type.
closes #6442
https://pulp.plan.io/issues/6442