Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for advisories resolution #1689

Merged
merged 1 commit into from May 14, 2020

Conversation

pavelpicka
Copy link
Contributor

@pavelpicka pavelpicka commented Apr 29, 2020

Added test for advisories conflict resolution

  • test merge of advisories
  • test newer version of advisory
  • newer added
  • newer exists and preserved
  • advisory with older update date is not added
  • negative tests for wrong/incomplete advisories metadata

re: #4142
https://pulp.plan.io/issues/4142

@pulpbot
Copy link
Member

pulpbot commented Apr 29, 2020

Attached issue: https://pulp.plan.io/issues/4142

@pavelpicka pavelpicka force-pushed the 4142-test-advisory branch 2 times, most recently from 59b59d7 to e485ce8 Compare April 29, 2020 18:56
@pep8speaks
Copy link

pep8speaks commented Apr 29, 2020

Hello @pavelpicka! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-05-14 10:11:12 UTC

@pavelpicka pavelpicka changed the title Add test for advisories resolution [WIP] Add test for advisories resolution Apr 29, 2020
pavelpicka added a commit to pavelpicka/pulp-fixtures that referenced this pull request May 6, 2020
new fixtures for advisory testing added with pulp/pulp_rpm#1689

re: #4142
https://pulp.plan.io/issues/4142
pavelpicka added a commit to pavelpicka/pulp-fixtures that referenced this pull request May 6, 2020
new fixtures for advisory testing added with pulp/pulp_rpm#1689

re: #4142
https://pulp.plan.io/issues/4142
daviddavis pushed a commit to pulp/pulp-fixtures that referenced this pull request May 6, 2020
new fixtures for advisory testing added with pulp/pulp_rpm#1689

re: #4142
https://pulp.plan.io/issues/4142
@pavelpicka pavelpicka force-pushed the 4142-test-advisory branch 7 times, most recently from 5a77d6a to ab84cec Compare May 11, 2020 08:27
@pavelpicka pavelpicka changed the title [WIP] Add test for advisories resolution Add test for advisories resolution May 11, 2020
pulp_rpm/tests/functional/api/test_sync.py Show resolved Hide resolved
pulp_rpm/tests/functional/api/test_sync.py Outdated Show resolved Hide resolved
pulp_rpm/tests/functional/api/test_sync.py Outdated Show resolved Hide resolved
pulp_rpm/tests/functional/api/test_sync.py Outdated Show resolved Hide resolved
pulp_rpm/tests/functional/constants.py Outdated Show resolved Hide resolved
pulp_rpm/tests/functional/api/test_sync.py Show resolved Hide resolved
pulp_rpm/tests/functional/api/test_sync.py Show resolved Hide resolved
@pavelpicka pavelpicka force-pushed the 4142-test-advisory branch 2 times, most recently from 1992172 to a1ea9be Compare May 13, 2020 14:30
)

def test_sync_advisory_updated_update_date(self):
"""Test sync advisory with updated update_date."""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc string is the same here and in the next test.

Added test for advisories conflict resolution
- test merge of advisories
- test newer version of advisory
 - newer added
 - newer exists and preserved
- advisory with older update date is not added
- negative tests for wrong/incomplete advisories metadata

re: #4142
https://pulp.plan.io/issues/4142
@goosemania goosemania merged commit 399c699 into pulp:master May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants