Fixing docs scripts on CI #1716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WARNING!!! This PR is not attached to an issue. In most cases this is not advisable. Please see our PR docs for more information about how to attach this PR to an issue. |
fao89
force-pushed
the
docs
branch
6 times, most recently
from
244e6d2
to
92ee5b0
Compare
[noissue] [nocoverage]
goosemania
reviewed
May 20, 2020
Comment on lines
+7
to
+8
| bash docs_check_upload.sh | ||
| bash docs_check_sync.sh |
There was a problem hiding this comment.
@fao89, does it make sense to test the docs_check_install_with_signed_repodata.sh as well?
There was a problem hiding this comment.
I tried but it was not possible because it tries to dnf install and travis uses ubuntu
There was a problem hiding this comment.
and I believe it makes sense to test it (and maybe other workflows), but I think it should be addressed on another issue, as it will require to run the scripts inside the container
There was a problem hiding this comment.
goosemania
approved these changes
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[noissue]
[nocoverage]