Improving Content handler tests #1722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Attached issue: https://pulp.plan.io/issues/6778 |
fao89
force-pushed
the
6778
branch
2 times, most recently
from
9730678
to
243ca7b
Compare
dkliban
requested changes
May 28, 2020
https://pulp.plan.io/issues/6778 closes #6778 [nocoverage]
fao89
commented
May 28, 2020
Comment on lines
+290
to
+304
| class PulpTestCase(TestCase): | ||
| """Pulp customized test case.""" | ||
|
|
||
| def doCleanups(self): | ||
| """ | ||
| Execute all cleanup functions and waits the deletion tasks. | ||
|
|
||
| Normally called for you after tearDown. | ||
| """ | ||
| output = super().doCleanups() | ||
| running_tasks = tasks.list(state="running", name__contains="delete") | ||
| while running_tasks.count: | ||
| sleep(0.3) | ||
| running_tasks = tasks.list(state="running", name__contains="delete") | ||
| return output |
There was a problem hiding this comment.
As the other tests were using addCleanup I introduced this TestCase that waits for the deletion tasks.
0.3 seconds as in pulp-smash.
dkliban
approved these changes
Jun 2, 2020
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://pulp.plan.io/issues/6778
closes #6778