Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PackageGroup related_packages removal #1745

Merged
merged 1 commit into from Jun 30, 2020

Conversation

pavelpicka
Copy link
Contributor

@pavelpicka pavelpicka commented Jun 8, 2020

PackageGroup doesn't specify package version so any can be used with list
of packages already present in PackageGroup.

[nocoverage]

closes: #6410
https://pulp.plan.io/issues/6410

@pulpbot
Copy link
Member

pulpbot commented Jun 8, 2020

Attached issue: https://pulp.plan.io/issues/6410

@pavelpicka pavelpicka force-pushed the 6410-packagegroup-relations branch 2 times, most recently from 696abd6 to 3d9f248 Compare June 8, 2020 10:38
@pavelpicka pavelpicka changed the title PackageGroup related_packages removal [WIP] PackageGroup related_packages removal Jun 8, 2020
@pavelpicka pavelpicka force-pushed the 6410-packagegroup-relations branch 5 times, most recently from 600e293 to bfd7e48 Compare June 18, 2020 11:49
@pavelpicka pavelpicka changed the title [WIP] PackageGroup related_packages removal PackageGroup related_packages removal Jun 18, 2020
@dralley
Copy link
Contributor

dralley commented Jun 18, 2020

This is an easy review since it's just removals :) LGTM

While it's still fresh in your mind, it would be good to start writing down any thoughts you have on how to implement copy in the issue [0], or even start a branch to prototype and work on implementing it so that if anything else needs to be done to make it work, we can know early.

[0] https://pulp.plan.io/issues/6316

@dralley
Copy link
Contributor

dralley commented Jun 19, 2020

@pavelpicka After thinking about it more I do think we should tie this work in together with https://pulp.plan.io/issues/6316 and merge it all together (maybe in this PR). That way we can know for certain that there are no issues with the strategy before we push this migration to users.

If you would like to work on this I would definitely be available to help and answer questions. It would be good to have someone else with experience working on the copy code :)

@pavelpicka pavelpicka changed the title PackageGroup related_packages removal [WIPPackageGroup related_packages removal Jun 23, 2020
@pavelpicka pavelpicka changed the title [WIPPackageGroup related_packages removal [WIP] PackageGroup related_packages removal Jun 23, 2020
@goosemania goosemania mentioned this pull request Jun 30, 2020
@pavelpicka pavelpicka changed the title [WIP] PackageGroup related_packages removal PackageGroup related_packages removal Jun 30, 2020
CHANGES/6410.removal Outdated Show resolved Hide resolved
@goosemania
Copy link
Member

Why commit says re? Is there another PR expected for that issue?

@pavelpicka
Copy link
Contributor Author

It is not. Updated to 'closes'.

PackageGroup doesn't specify package version so any package can be used with list of packages already present in PackageGroup.
Also removed relations to PackageGroup and each other for PackageCategory and PackageEnvironment.

[nocoverage]

closes: #6410
https://pulp.plan.io/issues/6410
@goosemania goosemania merged commit b6f2fd4 into pulp:master Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants