Remove FK to the main repo from a distribution tree Variant. #1782
Conversation
|
Attached issue: https://pulp.plan.io/issues/7150 |
goosemania
force-pushed
the
issue7150-no-fk
branch
from
a52e639
to
900633c
Compare
| is_main_repo = self._data[variant_key]["repository"] == DIST_TREE_MAIN_REPO_PATH | ||
| if is_main_repo: | ||
| repository = DIST_TREE_MAIN_REPO_PATH | ||
| packages = PACKAGES_DIRECTORY | ||
| else: |
There was a problem hiding this comment.
No change in logic here.
I had to reread this part many times, and always was confused, so I added the constant in a hope t o make it more readable.
| else: | ||
| repository = self._data[addon_key]["repository"] | ||
| packages = PACKAGES_DIRECTORY |
There was a problem hiding this comment.
I don't believe there is a case when addon can point to a main repo, or is there?
There was a problem hiding this comment.
Good question. I have no idea. I guess we can wait until we find one that does.
There was a problem hiding this comment.
I don't know, I did it because I thought it could be a possibility, but it was just a guess
|
@fao89 , @daviddavis, @dkliban , what's the purpose of this? |
No issues with repository removal. No issues with copying the same distribution tree into multiple repos. closes #7150 https://pulp.plan.io/issues/7150 closes #7096 https://pulp.plan.io/issues/7096 closes #7046 https://pulp.plan.io/issues/7046 [nocoverage]
goosemania
force-pushed
the
issue7150-no-fk
branch
from
900633c
to
ca39e84
Compare
it was a re-sync problem, the StagesAPI machinery could handle the DTs, but it was erroring on addons and variants |
There was a problem hiding this comment.
LGTM! I just have one question, have you ran the performance tests locally? These 2 tests provide good feedback: https://github.com/pulp/pulp_rpm/blob/master/pulp_rpm/tests/performance/test_pulp_to_pulp.py#L135-L141
|
@fao89 , I have not. I usually let cron do that. Why do you point to those 2 specifically? two non-kickstart ones? |
my intention was to point to the kickstart, I point those because one of them has 2 variants (and usually it is the one that breaks on CI for subtle changes) |
No issues with repository removal.
No issues with copying the same distribution tree into multiple repos.
closes #7150
https://pulp.plan.io/issues/7150