Sync to happen inside working directory

[pavelpicka]

few downloads or testing remote remomd.xml file happened outside a
working directory

closes: #7698
https://pulp.plan.io/issues/7698

[nocoverage]
[notest]

[pulpbot]

Attached issue: https://pulp.plan.io/issues/7698

[goosemania]

I think the suggested approach would work.
My question is whether it's easier/better to have only one context manager at the very beginning of the sync task which will cover all the code and not adding it selectively in many places.
I automatically think that one is better, just because iI don't need to remember in which place what happens and if any chages to it, they are in one place. Thoughts?

[pavelpicka]

It won't be easier as we can't call declarative_version.create inside context manager as it already uses one (https://github.com/pulp/pulpcore/blob/master/pulpcore/plugin/stages/declarative_version.py#L139). And in rpm sync we call declarative version multiple times as for main repo and many times if distribution trees are present.

[goosemania]

Oh that's a pain. I wish we could do get_or_create here https://github.com/pulp/pulpcore/blob/772e56e3cf5583fef0768dcc81b5cd8adb4b7ceb/pulpcore/tasking/services/storage.py#L168.

Could we reuse existing working directory? or is it a security or data consistency concern because of which we recreate it every time? The desire here is to support nested context manager:

with WorkingDirectory():
    ...
    with WorkingDirectory():
        ...

@daviddavis , @dralley , @bmbouter

[goosemania]

There needs to be an adjustment made in pulpcore. We discussed today to deprecate WorkingDirectory at all and move the working directory creation to the task management level. So for now I think we should merge it to fix the issue and after 3.10 we'll be able to remove this code.

[goosemania]

A typo (it should be outside of the) led me to a longer message to make it more user-friendly :)
What do you think?
Fixed the case when downloads were happening outside of the task working directory during sync.