Add support for automatic publishing and distributing #1938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Attached issue: https://pulp.plan.io/issues/7622 |
dralley
force-pushed
the
auto-publish-distribute
branch
12 times, most recently
from
d2ea502
to
e7c3450
Compare
dralley
force-pushed
the
auto-publish-distribute
branch
4 times, most recently
from
bc6e5d5
to
0497c43
Compare
dralley
commented
Feb 18, 2021
dralley
force-pushed
the
auto-publish-distribute
branch
11 times, most recently
from
338bbb8
to
d71e00e
Compare
dralley
force-pushed
the
auto-publish-distribute
branch
3 times, most recently
from
e0c89d6
to
bf9ae43
Compare
dralley
force-pushed
the
auto-publish-distribute
branch
from
bf9ae43
to
a072e12
Compare
dralley
force-pushed
the
auto-publish-distribute
branch
2 times, most recently
from
80cfa20
to
5029773
Compare
dralley
force-pushed
the
auto-publish-distribute
branch
5 times, most recently
from
38abc38
to
0df4619
Compare
goosemania
approved these changes
Apr 8, 2021
| def delete_remaining_old_master_model_entries(apps, schema_editor): | ||
| with connection.cursor() as cursor: | ||
| for pk in pks_to_delete: | ||
| cursor.execute("DELETE from core_basedistribution WHERE pulp_id = %s", [pk]) |
There was a problem hiding this comment.
Why are we deleting one by one? is it faster/better?
There was a problem hiding this comment.
Yeah I don't really get it either, but this was what Brian ended up doing. There was some discussion about it on the original file PR.
There was a problem hiding this comment.
At this point I'm not going to diverge from what was already tested / merged
There was a problem hiding this comment.
There's probably not enough distributions for it to make a lot of difference.
| @@ -205,6 +205,7 @@ class RpmRepository(Repository): | |||
| ModulemdDefaults, | |||
| ] | |||
| REMOTE_TYPES = [RpmRemote] | |||
| GPGCHECK_CHOICES = [(0, 0), (1, 1)] | |||
dralley
force-pushed
the
auto-publish-distribute
branch
4 times, most recently
from
e4130e2
to
80ddfe9
Compare
dralley
force-pushed
the
auto-publish-distribute
branch
from
80ddfe9
to
75eb93d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #7622
https://pulp.plan.io/issues/7622