Marking us as requiring core-3.12 until deprecations can be addressed. #1985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WARNING!!! This PR is not attached to an issue. In most cases this is not advisable. Please see our PR docs for more information about how to attach this PR to an issue. |
Also pin django to 2.2.14<=20 while we wait for a django-release. [noissue] [nocoverage]
daviddavis
approved these changes
May 11, 2021
mdellweg
reviewed
May 12, 2021
| @@ -1,4 +1,5 @@ | |||
| createrepo_c~=0.17.0 | |||
| django>=2.2.14,<=2.2.20 | |||
There was a problem hiding this comment.
maybe django~=2.2.14,!2.2.21,!2.2.22 can do the trick here.
https://www.python.org/dev/peps/pep-0440/#version-specifiers
There was a problem hiding this comment.
The issue with using the !... syntax is that a newer release that can come out and it would bring with it the problematic changes introduced in 2.2.21. I think leaving it as <=2.2.20 would prevent that better. Nice syntax tho.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[noissue]
[nocoverage]