Add relative_url as a valid config key for export distributor

[seandst]

https://pulp.plan.io/issues/1394
fixes #1394

pulp-admin support is conspicuously absent. There are some decisions to make for that, so I've opened up a new issue related to 1394 to deal with them.

[seandst]

ok test

[asmacdo]

ok test

[ipanova]

@seandst I think originally you checkouted from 2.7 and made the changes. So either you submitted against wring branch or you were supposed to checkout from master. Please fix that

[ipanova]

this will work only for API, you forgot to add the option for pulp-admin https://github.com/seandst/pulp_rpm/blob/1394-relative-url-export-config/extensions_admin/pulp_rpm/extensions/admin/export.py#L53

[seandst]

That's intentionally left out of this PR.

[ipanova]

@seandst also i think you should add the condition check of the situation where both export_dir and relative_url are provided and raise the error that you cannot use them together.

[beav]

Once this is merged, I can test it off of the nightly.

[seandst]

@beav it'll be a little while, I think, since this is currently (to use a technical term) broken as crap

I'll keep you updated. :)

[seandst]

This has been fixed up and should now work as intended, so it's ready for review.

I also added a fix to #1419, so you can now use the --relative-url option when using the pulp-admin rpm repo export subcommand to alter the location for that export.

You can also use the rest api to make the change before the export call. httpie e.g. http PUT https://localhost/pulp/api/v2/repositories/zoo/distributors/export_distributor/ distributor_config:='{"relative_url": "foo"}'

[seandst]

ok test

[ipanova]

@seandst i noticed that during repo creation( via pulp-admin), when you specify --relative url option it affects only yum_dist and not export_dist. Via API it works as supposed.

$ pulp-admin -vv rpm repo create --repo-id myrepo --relative-url different-url
Warning: path should have mode 0700 because it may contain sensitive information: /home/ipanova/.pulp/

2016-01-08 12:31:39,438 - DEBUG - sending POST request to /pulp/api/v2/repositories/
2016-01-08 12:31:39,583 - INFO - POST request to /pulp/api/v2/repositories/ with parameters {"display_name": null, "description": null, "distributors": [{"distributor_id": "yum_distributor", "auto_publish": true, "distributor_config": {"http": false, "relative_url": "different-url", "https": true}, "distributor_type_id": "yum_distributor"}, {"distributor_id": "export_distributor", "auto_publish": false, "distributor_config": {"http": false, "https": true}, "distributor_type_id": "export_distributor"}], "notes": {"_repo-type": "rpm-repo"}, "importer_type_id": "yum_importer", "importer_config": {}, "id": "myrepo"}
2016-01-08 12:31:39,584 - INFO - Response status : 201 

2016-01-08 12:31:39,584 - INFO - Response body :
 {
  "scratchpad": {}, 
  "display_name": null, 
  "description": null, 
  "last_unit_added": null, 
  "notes": {
    "_repo-type": "rpm-repo"
  }, 
  "last_unit_removed": null, 
  "content_unit_counts": {}, 
  "_ns": "repos", 
  "_id": {
    "$oid": "568f9e1b45ef4815db1c2d13"
  }, 
  "id": "myrepo", 
  "_href": "/pulp/api/v2/repositories/myrepo/"
}

Successfully created repository [myrepo]

$ curl -H "Accept: application/json" -X GET -k -u admin:admin 'https://localhost/pulp/api/v2/repositories/myrepo/distributors/export_distributor/'|python -m json.tool
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   368  100   368    0     0   1273      0 --:--:-- --:--:-- --:--:--  1273
{
    "_href": "/pulp/api/v2/repositories/myrepo/distributors/export_distributor/",
    "_id": {
        "$oid": "568f9e1b45ef4815db1c2d16"
    },
    "_ns": "repo_distributors",
    "auto_publish": false,
    "config": {
        "http": false,
        "https": true
    },
    "distributor_type_id": "export_distributor",
    "id": "export_distributor",
    "last_publish": "2016-01-08T11:38:07Z",
    "repo_id": "myrepo",
    "scratchpad": {}
}

[ipanova]

@seandst as far as i see you need to add relative_url to the export_dist_config_keys, which defaults to repo-id https://github.com/seandst/pulp_rpm/blob/1394-relative-url-export-config/extensions_admin/pulp_rpm/extensions/admin/repo_create_update.py#L37

[seandst]

@seandst i noticed that during repo creation( via pulp-admin), when you specify --relative url option it affects only yum_dist and not export_dist. Via API it works as supposed.

This is how it should work. Having relative-url affect the export distribute would be a backward-incompabile change. That's what https://pulp.plan.io/issues/1419 is about, so we can talk about it more there.

[seandst]

I got a conditional and verbal lgtm from ipanova after an IRC discussion. The condition is that the pulp-admin commit get moved into a second PR, and we'll discuss that bit further and address it in redmine #1419.