Removes symlink/file PULP_DISTRIBUTION.xml before writing a new file #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| try: | ||
| os.remove(distribution_xml_path) | ||
| except OSError, e: | ||
| if e.errno == 2: |
There was a problem hiding this comment.
magic_numbers--
dkliban
force-pushed
the
1869
branch
2 times, most recently
from
8fe42f9
to
16f5ac4
Compare
| try: | ||
| os.remove(distribution_xml_path) | ||
| except OSError as e: | ||
| if e.errno == os.errno.ENOENT: |
There was a problem hiding this comment.
I would usually save a couple of lines and do the following, but it's no big deal.
if e.errno != os.errno.ENOENT:
raise
|
LGTM, but I recommend at least one unit test that exercises the exception handling code, at least to cover the common case where the file doesn't exist. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1869
https://pulp.plan.io/issues/1869