This repository has been archived by the owner on Aug 19, 2020. It is now read-only.
Separate the pulp_installer CI tests: release vs source #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikedep333
force-pushed
the
6535_separate_tests
branch
5 times, most recently
from
9762825
to
38d4d53
Compare
Required PR: pulp/pulp_installer#269 re: #6535 [noissue]
mikedep333
force-pushed
the
6535_separate_tests
branch
from
38d4d53
to
6cc3abd
Compare
mikedep333
force-pushed
the
6535_separate_tests
branch
4 times, most recently
from
e20d9d1
to
04d57a9
Compare
fao89
reviewed
Apr 22, 2020
There was a problem hiding this comment.
I prefer the way you handled Required PR on galaxy installer than bringing plugin_template here:
https://github.com/fabricio-aguiar/galaxy_ng_prerequisites/pull/3/files
fixes: #6553 Required PR: pulp/pulp_installer#269
mikedep333
force-pushed
the
6535_separate_tests
branch
from
04d57a9
to
9a94f72
Compare
I think for one only 1 referenced repo, that make sense. I was mostly focused on avoiding writing duplicate code. At this point, I just want to merge. I am likely to rework this section of code later when I implement another task in this story for checking out pulp_installer branches. (e.g., pulp_rpm_prerequisites 3.3 branch would use pulp_installer 3.3 branch, rather than setting the pulp_version variable in pulp_installer master.) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required PR: pulp/pulp_installer#269
re: #6535
[noissue]