This repository has been archived by the owner on Oct 28, 2019. It is now read-only.
Updating docs for subclassing models #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #119 +/- ##
=======================================
Coverage 42.72% 42.72%
=======================================
Files 22 22
Lines 735 735
=======================================
Hits 314 314
Misses 421 421Continue to review full report at Codecov.
|
fao89
force-pushed
the
4681-related-name
branch
from
5a57736
to
e8a3ea9
Compare
daviddavis
reviewed
Aug 12, 2019
fao89
force-pushed
the
4681-related-name
branch
from
e8a3ea9
to
3c44c31
Compare
fao89
force-pushed
the
4681-related-name
branch
from
3c44c31
to
8a6bef4
Compare
daviddavis
reviewed
Aug 19, 2019
CHANGES/4681.feature
Outdated
| @@ -0,0 +1 @@ | |||
| Breaking change on how to subclass Master/Detail models in plugins. | |||
There was a problem hiding this comment.
Per https://github.com/pulp/pulpcore/pull/259/files#r313088909, I think this file should be renamed to 4681.bugfix. Also, add some text that 'default_related_name' is now required for Detail models.
ref #4681
fao89
force-pushed
the
4681-related-name
branch
from
8a6bef4
to
af1e844
Compare
daviddavis
approved these changes
Aug 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #4681
related to: pulp/pulpcore#259