This repository has been archived by the owner on Oct 28, 2019. It is now read-only.
adding code on progress bar #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fao89
added a commit
to fao89/pulpcore
that referenced
this pull request
Sep 10, 2019
closes #5184 Required PR: pulp/pulp_file#272 Required PR: pulp/pulpcore-plugin#123 https://pulp.plan.io/issues/5184
fao89
added a commit
to fao89/pulp_file
that referenced
this pull request
Sep 10, 2019
ref #5184 https://pulp.plan.io/issues/5184 Required PR: pulp/pulpcore-plugin#123 Required PR: pulp/pulpcore#289
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
=========================================
- Coverage 42.68% 42.09% -0.6%
=========================================
Files 22 21 -1
Lines 738 727 -11
=========================================
- Hits 315 306 -9
+ Misses 423 421 -2
Continue to review full report at Codecov.
|
fao89
added a commit
to fao89/pulp_rpm
that referenced
this pull request
Sep 10, 2019
ref #5184 https://pulp.plan.io/issues/5184 Required PR: pulp/pulpcore-plugin#123 Required PR: pulp/pulpcore#289
fao89
added a commit
to fao89/pulp_rpm
that referenced
this pull request
Sep 10, 2019
ref #5184 https://pulp.plan.io/issues/5184 Required PR: pulp/pulpcore-plugin#123 Required PR: pulp/pulpcore#289
|
Does it make sense to create a pre-defined set of codes which will be likely used by plugins as well? The goal is to make it easier to have at least some consistency in the code names across plugins. E.g. sync, publish, parsing metadata, etc. |
@goosemania I believe it makes sense, but I don't know what would be these set of codes, and in some cases, it is hard to define what would be the code to differentiate the progress bars, like in this case: https://github.com/pulp/pulp_rpm/pull/1437/files |
daviddavis
reviewed
Sep 13, 2019
CHANGES/5184.misc
Outdated
| @@ -0,0 +1 @@ | |||
| Adding `code` on `ProgressBar`. | |||
There was a problem hiding this comment.
This needs to probably be a feature.
daviddavis
reviewed
Sep 13, 2019
| @@ -78,7 +78,7 @@ def __init__(self, new_version, *args, **kwargs): | |||
| Returns: | |||
| The coroutine for this stage. | |||
| """ | |||
| with ProgressBar(message='Un-Associating Content') as pb: | |||
| with ProgressBar(message='Un-Associating Content', code='un-associating.content') as pb: | |||
There was a problem hiding this comment.
s/un-associating/unassociating/
fao89
added a commit
to fao89/pulpcore
that referenced
this pull request
Sep 13, 2019
closes #5184 Required PR: pulp/pulp_file#272 Required PR: pulp/pulpcore-plugin#123 https://pulp.plan.io/issues/5184
ref #5184 https://pulp.plan.io/issues/5184 Required PR: pulp/pulpcore#289 Required PR: pulp/pulp_file#272
fao89
added a commit
to fao89/pulp_file
that referenced
this pull request
Sep 13, 2019
ref #5184 https://pulp.plan.io/issues/5184 Required PR: pulp/pulpcore-plugin#123 Required PR: pulp/pulpcore#289
fao89
added a commit
to fao89/pulp_rpm
that referenced
this pull request
Sep 13, 2019
ref #5184 https://pulp.plan.io/issues/5184 Required PR: pulp/pulpcore-plugin#123 Required PR: pulp/pulpcore#289
fao89
added a commit
to fao89/pulpcore
that referenced
this pull request
Sep 13, 2019
closes #5184 Required PR: pulp/pulp_file#272 Required PR: pulp/pulpcore-plugin#123 https://pulp.plan.io/issues/5184
daviddavis
pushed a commit
to pulp/pulpcore
that referenced
this pull request
Sep 13, 2019
closes #5184 Required PR: pulp/pulp_file#272 Required PR: pulp/pulpcore-plugin#123 https://pulp.plan.io/issues/5184
daviddavis
pushed a commit
to pulp/pulp_ansible
that referenced
this pull request
Sep 13, 2019
ref #5184 https://pulp.plan.io/issues/5184 Required PR: pulp/pulpcore-plugin#123 Required PR: pulp/pulpcore#289
daviddavis
pushed a commit
to pulp/pulp_file
that referenced
this pull request
Sep 13, 2019
ref #5184 https://pulp.plan.io/issues/5184 Required PR: pulp/pulpcore-plugin#123 Required PR: pulp/pulpcore#289
daviddavis
approved these changes
Sep 13, 2019
daviddavis
pushed a commit
to daviddavis/pulp_rpm
that referenced
this pull request
Sep 13, 2019
ref #5184 https://pulp.plan.io/issues/5184 Required PR: pulp/pulpcore-plugin#123 Required PR: pulp/pulpcore#289
daviddavis
pushed a commit
to daviddavis/pulp_rpm
that referenced
this pull request
Sep 13, 2019
ref #5184 https://pulp.plan.io/issues/5184 Required PR: pulp/pulpcore-plugin#123 Required PR: pulp/pulpcore#289
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #5184
https://pulp.plan.io/issues/5184
Required PR: pulp/pulpcore#289
Required PR: pulp/pulp_file#272
Please be sure you have read our documentation on creating PRs:
https://docs.pulpproject.org/en/3.0/nightly/contributing/pull-request-walkthrough.html