This repository has been archived by the owner on Oct 28, 2019. It is now read-only.
Replace ProgressBar with ProgressReport #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fao89
added a commit
to fao89/pulpcore
that referenced
this pull request
Sep 10, 2019
closes #5164 Required PR: pulp/pulpcore-plugin#127 https://pulp.plan.io/issues/5164
Codecov Report
@@ Coverage Diff @@
## master #127 +/- ##
=========================================
- Coverage 42.56% 41.97% -0.6%
=========================================
Files 22 21 -1
Lines 740 729 -11
=========================================
- Hits 315 306 -9
+ Misses 425 423 -2
Continue to review full report at Codecov.
|
fao89
added a commit
to fao89/pulpcore
that referenced
this pull request
Sep 11, 2019
closes #5164 Required PR: pulp/pulpcore-plugin#127 https://pulp.plan.io/issues/5164
fao89
added a commit
to fao89/pulpcore
that referenced
this pull request
Sep 17, 2019
closes #5164 Required PR: pulp/pulpcore-plugin#127 https://pulp.plan.io/issues/5164
fao89
added a commit
to fao89/pulpcore
that referenced
this pull request
Sep 17, 2019
closes #5164 Required PR: pulp/pulpcore-plugin#127 https://pulp.plan.io/issues/5164
fao89
added a commit
to fao89/pulp_file
that referenced
this pull request
Sep 17, 2019
ref #5444 Required PR: pulp/pulpcore#293 Required PR: pulp/pulpcore-plugin#127
fao89
changed the title
fao89
force-pushed
the
5164
branch
2 times, most recently
from
cfd6b2f
to
dd1557f
Compare
fao89
added a commit
to fao89/pulpcore
that referenced
this pull request
Sep 17, 2019
closes #5444 https://pulp.plan.io/issues/5444 Required PR: pulp/pulpcore-plugin#127 Required PR: pulp/pulp_file#277
fao89
added a commit
to fao89/pulp_file
that referenced
this pull request
Sep 17, 2019
ref #5444 Required PR: pulp/pulpcore#293 Required PR: pulp/pulpcore-plugin#127
fao89
added a commit
to fao89/pulpcore
that referenced
this pull request
Sep 17, 2019
closes #5444 https://pulp.plan.io/issues/5444 Required PR: pulp/pulpcore-plugin#127 Required PR: pulp/pulp_file#277
bmbouter
reviewed
Sep 17, 2019
| @@ -0,0 +1 @@ | |||
| Replace `ProgressBar` with `ProgressReport`. | |||
There was a problem hiding this comment.
Can this become part of the 5444.removal? The motivation is that the template we use makes misc entries not show the text so the actual changelog won't include this.
There was a problem hiding this comment.
In pulp_deb we decided to ignore the show_content flag in the template, because we thought, the misc entries are equally valid.
There was a problem hiding this comment.
Maybe we should also but another time.
|
Can you look at the docs section also. If you render the docs locally with |
ref #5444 https://pulp.plan.io/issues/5444 Required PR: pulp/pulpcore#293 Required PR: pulp/pulp_file#277
fao89
added a commit
to fao89/pulpcore
that referenced
this pull request
Sep 17, 2019
closes #5444 https://pulp.plan.io/issues/5444 Required PR: pulp/pulpcore-plugin#127 Required PR: pulp/pulp_file#277
|
@fabricio-aguiar can you also open a PR for the plugin_template. I see at least a few usages there: https://github.com/pulp/plugin_template/search?q=ProgressBar&unscoped_q=ProgressBar |
|
fao89
added a commit
to fao89/pulpcore
that referenced
this pull request
Sep 17, 2019
closes #5444 https://pulp.plan.io/issues/5444 Required PR: pulp/pulpcore-plugin#127 Required PR: pulp/pulp_file#277
fao89
added a commit
to fao89/pulp-2to3-migration
that referenced
this pull request
Sep 18, 2019
ref #5444 https://pulp.plan.io/issues/5444 Required PR: pulp/pulpcore#293 Required PR: pulp/pulpcore-plugin#127 Required PR: pulp/pulp_file#277
This was referenced Sep 18, 2019
fao89
added a commit
to fao89/pulp_deb
that referenced
this pull request
Sep 18, 2019
closes #5477 https://pulp.plan.io/issues/5477 Required PR: pulp/pulpcore#293 Required PR: pulp/pulpcore-plugin#127 Required PR: pulp/pulp_file#277
fao89
added a commit
to fao89/pulp_rpm
that referenced
this pull request
Sep 18, 2019
closes #5469 https://pulp.plan.io/issues/5469 Required PR: pulp/pulpcore#293 Required PR: pulp/pulpcore-plugin#127 Required PR: pulp/pulp_file#277
fao89
added a commit
to fao89/pulp_python
that referenced
this pull request
Sep 18, 2019
closes #5471 https://pulp.plan.io/issues/5471 Required PR: pulp/pulpcore#293 Required PR: pulp/pulpcore-plugin#127 Required PR: pulp/pulp_file#277
fao89
added a commit
to fao89/pulp_docker
that referenced
this pull request
Sep 18, 2019
closes #5470 https://pulp.plan.io/issues/5470 Required PR: pulp/pulpcore#293 Required PR: pulp/pulpcore-plugin#127 Required PR: pulp/pulp_file#277
fao89
added a commit
to fao89/pulpcore
that referenced
this pull request
Sep 18, 2019
closes #5444 https://pulp.plan.io/issues/5444 Required PR: pulp/pulpcore-plugin#127 Required PR: pulp/pulp_file#277
fao89
added a commit
to fao89/pulpcore
that referenced
this pull request
Sep 18, 2019
closes #5444 https://pulp.plan.io/issues/5444 Required PR: pulp/pulpcore-plugin#127 Required PR: pulp/pulp_file#277
fao89
added a commit
to fao89/pulp-2to3-migration
that referenced
this pull request
Sep 19, 2019
ref #5444 https://pulp.plan.io/issues/5444 Required PR: pulp/pulpcore#293 Required PR: pulp/pulpcore-plugin#127 Required PR: pulp/pulp_file#277
bmbouter
approved these changes
Sep 19, 2019
fao89
added a commit
to fao89/pulpcore
that referenced
this pull request
Sep 19, 2019
closes #5444 https://pulp.plan.io/issues/5444 Required PR: pulp/pulpcore-plugin#127 Required PR: pulp/pulp_file#277
fao89
added a commit
to fao89/pulp_rpm
that referenced
this pull request
Sep 19, 2019
closes #5469 https://pulp.plan.io/issues/5469 Required PR: pulp/pulpcore#293 Required PR: pulp/pulpcore-plugin#127 Required PR: pulp/pulp_file#277
fao89
added a commit
to fao89/pulp_python
that referenced
this pull request
Sep 19, 2019
closes #5471 https://pulp.plan.io/issues/5471 Required PR: pulp/pulpcore#293 Required PR: pulp/pulpcore-plugin#127 Required PR: pulp/pulp_file#277
fao89
added a commit
to fao89/pulp_docker
that referenced
this pull request
Sep 19, 2019
closes #5470 https://pulp.plan.io/issues/5470 Required PR: pulp/pulpcore#293 Required PR: pulp/pulpcore-plugin#127 Required PR: pulp/pulp_file#277
fao89
added a commit
to fao89/pulp_rpm
that referenced
this pull request
Sep 19, 2019
closes #5469 https://pulp.plan.io/issues/5469 Required PR: pulp/pulpcore#293 Required PR: pulp/pulpcore-plugin#127 Required PR: pulp/pulp_file#277
fao89
added a commit
to fao89/pulp_docker
that referenced
this pull request
Sep 20, 2019
closes #5470 https://pulp.plan.io/issues/5470 Required PR: pulp/pulpcore#293 Required PR: pulp/pulpcore-plugin#127 Required PR: pulp/pulp_file#277
fao89
added a commit
to fao89/pulp_rpm
that referenced
this pull request
Sep 20, 2019
closes #5469 https://pulp.plan.io/issues/5469 Required PR: pulp/pulpcore#293 Required PR: pulp/pulpcore-plugin#127 Required PR: pulp/pulp_file#277
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #5444
https://pulp.plan.io/issues/5444
Please be sure you have read our documentation on creating PRs:
https://docs.pulpproject.org/en/3.0/nightly/contributing/pull-request-walkthrough.html