This repository has been archived by the owner on Oct 28, 2019. It is now read-only.
Remove JSONField from public API #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this needs a |
dralley
force-pushed
the
rm-jsonfield
branch
from
a79d944
to
6cc0f17
Compare
|
@daviddavis updated |
daviddavis
approved these changes
Sep 18, 2019
dralley
force-pushed
the
rm-jsonfield
branch
from
6cc0f17
to
1de9253
Compare
We're using Django's from now on, not our own. re: #5465 https://pulp.plan.io/issues/5465
dralley
force-pushed
the
rm-jsonfield
branch
from
1de9253
to
5f7fcf2
Compare
Codecov Report
@@ Coverage Diff @@
## master #132 +/- ##
==========================================
+ Coverage 41.97% 42.56% +0.59%
==========================================
Files 21 22 +1
Lines 729 740 +11
==========================================
+ Hits 306 315 +9
- Misses 423 425 +2
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're using Django's from now on, not our own.
re: 5465
https://pulp.plan.io/issues/5465
Please be sure you have read our documentation on creating PRs:
https://docs.pulpproject.org/en/3.0/nightly/contributing/pull-request-walkthrough.html