Skip to content
This repository has been archived by the owner on Oct 28, 2019. It is now read-only.

Add change log entries for PublishedMetadata change #133

Merged
merged 1 commit into from Sep 26, 2019

Conversation

dkliban
Copy link
Member

@dkliban dkliban commented Sep 19, 2019

@codecov
Copy link

codecov bot commented Sep 19, 2019

Codecov Report

Merging #133 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #133   +/-   ##
=======================================
  Coverage   42.56%   42.56%           
=======================================
  Files          22       22           
  Lines         740      740           
=======================================
  Hits          315      315           
  Misses        425      425

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71d6d1d...c4e70eb. Read the comment docs.

Copy link
Member

@bmbouter bmbouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one line like this in the docs that needs an update: PublishedMetadata is a repository metadata which is published, located in /var/lib/pulp/published and belongs to a certain Publication.

I saw it from this query: https://docs.pulpproject.org/en/pulpcore-plugin/nightly/search.html?q=PublishedMetadata&check_keywords=yes&area=default

@bmbouter
Copy link
Member

Also this example uses the default constructor: metadata = PublishedMetadata(...) https://docs.pulpproject.org/en/pulpcore-plugin/nightly/api-reference/models.html?highlight=publishedmetadata

@dkliban
Copy link
Member Author

dkliban commented Sep 19, 2019

I pushed the changes you suggested. One of them had to be made in the pulpcore PR.

Copy link
Member

@bmbouter bmbouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good; thank you for doing the additional docs.

@dkliban dkliban merged commit ebb8abc into pulp:master Sep 26, 2019
@dkliban dkliban deleted the publishedmetadata branch September 26, 2019 01:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants