Add ReadOnlyContentViewset #140
Conversation
re #5535 https://pulp.plan.io/issues/5535 Required PR: pulp/pulpcore#322 Required PR: pulp/pulpcore-plugin#140
CHANGES/5535.feature
Outdated
| @@ -0,0 +1,2 @@ | |||
| Add a ReadOnlyContentViewSet for plugin wirters. | |||
|
|
|||
There was a problem hiding this comment.
I think this will look visually inconsistent in the rendered changelog. I recommend removing the extra line.
There was a problem hiding this comment.
Sure, I can remove it. Sometimes it complains about lack of newline and I merge PRs in pulp_rpm with a newline and I don't think it affected release notes. No problem to remove it.
| @@ -12,6 +12,7 @@ | |||
| NamedModelViewSet, | |||
There was a problem hiding this comment.
Do we still want NamedModelViewSet in the plugin API?
There was a problem hiding this comment.
I would assume so. It's the base viewset for models and is being used in plugins like pulp_docker and pulp_ansible.
There was a problem hiding this comment.
I think so. What if it's not content but some other very custom viewset.
There was a problem hiding this comment.
This sounds good. +1 Thank you.
| @@ -12,6 +12,7 @@ | |||
| NamedModelViewSet, | |||
| PublicationViewSet, | |||
| PublisherViewSet, | |||
| ReadOnlyContentViewSet, | |||
There was a problem hiding this comment.
Do we also want to add BaseContentViewSet so plugin writer's can use that as an equivalent to the "generic" use case?
There was a problem hiding this comment.
I could go either way although my rule of thumb is to never add anything unless someone needs it.
There was a problem hiding this comment.
My thinking is that we don't add it to the plugin API until we needed. I'm not against adding it right away if you think it's useful to do it now.
There was a problem hiding this comment.
This works for me. Let's add it later.
re #5535 https://pulp.plan.io/issues/5535 Required PR: pulp/pulpcore#322
re #5535 https://pulp.plan.io/issues/5535 Required PR: pulp/pulpcore#322 Required PR: pulp/pulpcore-plugin#140
re #5535
https://pulp.plan.io/issues/5535
Required PR: pulp/pulpcore#322