This repository has been archived by the owner on Oct 28, 2019. It is now read-only.
Make changes to support UUID Primary Keys #69
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ada3809
to
af41c69
Compare
dralley
added a commit
to dralley/pulpcore
that referenced
this pull request
Mar 4, 2019
ff7c22e
to
d192f50
Compare
daviddavis
approved these changes
Mar 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes LGTM
334c7ab
to
e186c6a
Compare
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
==========================================
- Coverage 42.85% 42.69% -0.17%
==========================================
Files 22 22
Lines 707 712 +5
==========================================
+ Hits 303 304 +1
- Misses 404 408 +4
Continue to review full report at Codecov.
|
dralley
added a commit
to dralley/pulpcore
that referenced
this pull request
Mar 5, 2019
dralley
added a commit
to dralley/pulpcore
that referenced
this pull request
Mar 5, 2019
dralley
added a commit
to dralley/pulpcore
that referenced
this pull request
Mar 6, 2019
daviddavis
pushed a commit
to daviddavis/pulpcore
that referenced
this pull request
Mar 7, 2019
daviddavis
pushed a commit
to daviddavis/pulpcore
that referenced
this pull request
Mar 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re: #4270
https://pulp.plan.io/issues/4270