Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no way for users to prevent creation_hooks from running without editing every AccessPolicy to remove them #2116

Closed
bmbouter opened this issue Jan 19, 2022 · 0 comments · Fixed by #2198
Assignees
Labels

Comments

@bmbouter
Copy link
Member

bmbouter commented Jan 19, 2022

Problem

Users want to fully disable the default Authorization of pulp by modifying the DEFAULT_PERMISSION_CLASSES, but even if they do the creation hooks will still be running, likely assigned unwanted permissions to various users and groups.

Solution

Have the calling of creation_hooks happen in side an interface on AccessPolicyFromDB, e.g. named handle_creation_hooks or some reasonable name. By delegating the running of creation hooks onto that object, when the user changes it, they won't run anymore.

@bmbouter bmbouter self-assigned this Jan 25, 2022
@dkliban dkliban added the Story label Jan 25, 2022
@dkliban dkliban added this to the 3.18.0 blockers milestone Feb 2, 2022
@dralley dralley added Feature and removed Story labels Feb 2, 2022
bmbouter added a commit to bmbouter/pulpcore that referenced this issue Feb 2, 2022
This change adds the `handle_creation_hooks` interface to the
``AccessPolicyFromDB`` method. If the AccessPolicy configured does not
have that interface, new model instances created will not have
permissions automatically added to them.

closes pulp#2116
bmbouter added a commit to bmbouter/pulpcore that referenced this issue Feb 2, 2022
This change adds the `handle_creation_hooks` interface to the
``AccessPolicyFromDB`` method. If the AccessPolicy configured does not
have that interface, new model instances created will not have
permissions automatically added to them.

closes pulp#2116
bmbouter added a commit to bmbouter/pulpcore that referenced this issue Feb 7, 2022
This change adds the `handle_creation_hooks` interface to the
``AccessPolicyFromDB`` method. If the AccessPolicy configured does not
have that interface, new model instances created will not have
permissions automatically added to them.

closes pulp#2116
bmbouter added a commit to bmbouter/pulpcore that referenced this issue Feb 7, 2022
This change adds the `handle_creation_hooks` interface to the
``AccessPolicyFromDB`` method. If the AccessPolicy configured does not
have that interface, new model instances created will not have
permissions automatically added to them.

closes pulp#2116
bmbouter added a commit to bmbouter/pulpcore that referenced this issue Feb 7, 2022
This change adds the `handle_creation_hooks` interface to the
``AccessPolicyFromDB`` method. If the AccessPolicy configured does not
have that interface, new model instances created will not have
permissions automatically added to them.

closes pulp#2116
bmbouter added a commit to bmbouter/pulpcore that referenced this issue Feb 7, 2022
This change adds the `handle_creation_hooks` interface to the
``AccessPolicyFromDB`` method. If the AccessPolicy configured does not
have that interface, new model instances created will not have
permissions automatically added to them.

closes pulp#2116
bmbouter added a commit to bmbouter/pulpcore that referenced this issue Feb 7, 2022
This change adds the `handle_creation_hooks` interface to the
``AccessPolicyFromDB`` method. If the AccessPolicy configured does not
have that interface, new model instances created will not have
permissions automatically added to them.

closes pulp#2116
bmbouter added a commit to bmbouter/pulpcore that referenced this issue Feb 8, 2022
This change adds the `handle_creation_hooks` interface to the
``AccessPolicyFromDB`` method. If the AccessPolicy configured does not
have that interface, new model instances created will not have
permissions automatically added to them.

closes pulp#2116
bmbouter added a commit to bmbouter/pulpcore that referenced this issue Feb 8, 2022
This change adds the `handle_creation_hooks` interface to the
`AccessPolicyFromDB` method. If the AccessPolicy configured does not
have that interface, new model instances created will not have
permissions automatically added to them.

closes pulp#2116
bmbouter added a commit to bmbouter/pulpcore that referenced this issue Feb 8, 2022
This change adds the `handle_creation_hooks` interface to the
`AccessPolicyFromDB` method. If the AccessPolicy configured does not
have that interface, new model instances created will not have
permissions automatically added to them.

closes pulp#2116
bmbouter added a commit to bmbouter/pulpcore that referenced this issue Feb 9, 2022
This change adds the `handle_creation_hooks` interface to the
`AccessPolicyFromDB` method. If the AccessPolicy configured does not
have that interface, new model instances created will not have
permissions automatically added to them.

closes pulp#2116
bmbouter added a commit to bmbouter/pulpcore that referenced this issue Feb 9, 2022
This change adds the `handle_creation_hooks` interface to the
`AccessPolicyFromDB` method. If the AccessPolicy configured does not
have that interface, new model instances created will not have
permissions automatically added to them.

closes pulp#2116
bmbouter added a commit to bmbouter/pulpcore that referenced this issue Feb 9, 2022
This change adds the `handle_creation_hooks` interface to the
`AccessPolicyFromDB` method. If the AccessPolicy configured does not
have that interface, new model instances created will not have
permissions automatically added to them.

closes pulp#2116
bmbouter added a commit to bmbouter/pulpcore that referenced this issue Feb 9, 2022
This change adds the `handle_creation_hooks` interface to the
`AccessPolicyFromDB` method. If the AccessPolicy configured does not
have that interface, new model instances created will not have
permissions automatically added to them.

closes pulp#2116
bmbouter added a commit to bmbouter/pulpcore that referenced this issue Feb 9, 2022
This change adds the `handle_creation_hooks` interface to the
`AccessPolicyFromDB` method. If the AccessPolicy configured does not
have that interface, new model instances created will not have
permissions automatically added to them.

closes pulp#2116
bmbouter added a commit that referenced this issue Feb 9, 2022
This change adds the `handle_creation_hooks` interface to the
`AccessPolicyFromDB` method. If the AccessPolicy configured does not
have that interface, new model instances created will not have
permissions automatically added to them.

closes #2116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants