Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of does_batch in DeclarativeContent is wrong #2557

Closed
mdellweg opened this issue Apr 19, 2022 · 0 comments · Fixed by #2558
Closed

Implementation of does_batch in DeclarativeContent is wrong #2557

mdellweg opened this issue Apr 19, 2022 · 0 comments · Fixed by #2558
Labels

Comments

@mdellweg
Copy link
Member

Describe the bug
does_batch is supposed to decide, whether content can be waited on, or must be evaluated asap. It produces False unnecessarily often, leading to performance issues.

Additional context
This is suspected to at least one of the reasons for: pulp/pulp_deb#466

mdellweg added a commit to mdellweg/pulpcore that referenced this issue Apr 19, 2022
This bug lead to serious sync performance degredation in some plugins,
because batching was de facto disabled for the ContentAssociation stage.

fixes pulp#2557
dralley pushed a commit that referenced this issue Apr 20, 2022
This bug lead to serious sync performance degredation in some plugins,
because batching was de facto disabled for the ContentAssociation stage.

fixes #2557
patchback bot pushed a commit that referenced this issue Apr 20, 2022
This bug lead to serious sync performance degredation in some plugins,
because batching was de facto disabled for the ContentAssociation stage.

fixes #2557

(cherry picked from commit cc535cc)
patchback bot pushed a commit that referenced this issue Apr 20, 2022
This bug lead to serious sync performance degredation in some plugins,
because batching was de facto disabled for the ContentAssociation stage.

fixes #2557

(cherry picked from commit cc535cc)
patchback bot pushed a commit that referenced this issue Apr 20, 2022
This bug lead to serious sync performance degredation in some plugins,
because batching was de facto disabled for the ContentAssociation stage.

fixes #2557

(cherry picked from commit cc535cc)
patchback bot pushed a commit that referenced this issue Apr 20, 2022
This bug lead to serious sync performance degredation in some plugins,
because batching was de facto disabled for the ContentAssociation stage.

fixes #2557

(cherry picked from commit cc535cc)
mdellweg added a commit that referenced this issue Apr 20, 2022
This bug lead to serious sync performance degredation in some plugins,
because batching was de facto disabled for the ContentAssociation stage.

fixes #2557

(cherry picked from commit cc535cc)
mdellweg added a commit that referenced this issue Apr 20, 2022
This bug lead to serious sync performance degredation in some plugins,
because batching was de facto disabled for the ContentAssociation stage.

fixes #2557

(cherry picked from commit cc535cc)
mdellweg added a commit that referenced this issue Apr 20, 2022
This bug lead to serious sync performance degredation in some plugins,
because batching was de facto disabled for the ContentAssociation stage.

fixes #2557

(cherry picked from commit cc535cc)
mdellweg added a commit that referenced this issue Apr 20, 2022
This bug lead to serious sync performance degredation in some plugins,
because batching was de facto disabled for the ContentAssociation stage.

fixes #2557

(cherry picked from commit cc535cc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants