Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse existing artifact and content units in case the user provided proof that they have the bits #3081

Closed
MichalPysik opened this issue Aug 16, 2022 · 0 comments · Fixed by #3083
Closed

Reuse existing artifact and content units in case the user provided proof that they have the bits #3081

MichalPysik opened this issue Aug 16, 2022 · 0 comments · Fixed by #3083
Assignees
@MichalPysik
Labels
Feature

Comments

@MichalPysik
Copy link
Member

On content upload, pulp should not reject the request for any uniqueness constraint violation, but realize that the user was able to provide the bits and therefor grant using the existing records, which means not throwing an exception and returning the href of the existing object, possibly also adding it into a repository if it was specified.

This is a generalization of https://github.com/pulp/pulp_file/issues/774
@MichalPysik MichalPysik self-assigned this Aug 16, 2022
MichalPysik added a commit to MichalPysik/pulpcore that referenced this issue Aug 16, 2022
@MichalPysik
Allow uploading existing content
3772569 
Attempting to upload existing content now returns the href of the
existing unit instead of raising an exception, possibly also adding
the content into a specified repository if it was not there already.

To make this work for a specific plugin, the retrieve() function
has to be implemented in the content serializer specific for the
given plugin. This commit does not break the behavior of plugins
not containing this implementation yet in any way.

closes pulp#3081
MichalPysik added a commit to MichalPysik/pulpcore that referenced this issue Aug 16, 2022
@MichalPysik
Allow uploading existing content
1972988 
Attempting to upload existing content now returns the href of the
existing unit instead of raising an exception, possibly also adding
the content into a specified repository if it was not there already.

To make this work for a specific plugin, the retrieve() function
has to be implemented in the content serializer specific for the
given plugin. This commit does not break the behavior of plugins
not containing this implementation yet in any way.

closes pulp#3081
@MichalPysik MichalPysik mentioned this issue Aug 16, 2022
Merged
MichalPysik added a commit to MichalPysik/pulpcore that referenced this issue Aug 16, 2022
@MichalPysik
Allow uploading existing content
114b47e 
Attempting to upload existing content now returns the href of the
existing unit instead of raising an exception, possibly also adding
the content into a specified repository if it was not there already.

To make this work for a specific plugin, the retrieve() function
has to be implemented in the content serializer specific for the
given plugin. This commit does not break the behavior of plugins
not containing this implementation yet in any way.

closes pulp#3081
MichalPysik added a commit to MichalPysik/pulpcore that referenced this issue Aug 16, 2022
@MichalPysik
Allow uploading existing content
1284093 
Attempting to upload existing content now returns the href of the
existing unit instead of raising an exception, possibly also adding
the content into a specified repository if it was not there already.

To make this work for a specific plugin, the retrieve() function
has to be implemented in the content serializer specific for the
given plugin. This commit does not break the behavior of plugins
not containing this implementation yet in any way.

closes pulp#3081
MichalPysik added a commit to MichalPysik/pulpcore that referenced this issue Aug 23, 2022
@MichalPysik
Allow uploading existing content
9ed5588 
Attempting to upload existing content now returns the href of the
existing unit instead of raising an exception, possibly also adding
the content into a specified repository if it was not there already.

To make this work for a specific plugin, the retrieve() function
has to be implemented in the content serializer specific for the
given plugin. This commit does not break the behavior of plugins
not containing this implementation yet in any way.

closes pulp#3081
MichalPysik added a commit to MichalPysik/pulpcore that referenced this issue Aug 23, 2022
@MichalPysik
Allow uploading existing content
54be988 
Attempting to upload existing content now returns the href of the
existing unit instead of raising an exception, possibly also adding
the content into a specified repository if it was not there already.

To make this work for a specific plugin, the retrieve() function
has to be implemented in the content serializer specific for the
given plugin. This commit does not break the behavior of plugins
not containing this implementation yet in any way.

closes pulp#3081
MichalPysik added a commit to MichalPysik/pulpcore that referenced this issue Aug 23, 2022
@MichalPysik
Allow uploading existing content
f0e848f 
Attempting to upload existing content now returns the href of the
existing unit instead of raising an exception, possibly also adding
the content into a specified repository if it was not there already.

To make this work for a specific plugin, the retrieve() function
has to be implemented in the content serializer specific for the
given plugin. This commit does not break the behavior of plugins
not containing this implementation yet in any way.

closes pulp#3081
MichalPysik added a commit to MichalPysik/pulpcore that referenced this issue Aug 23, 2022
@MichalPysik
Allow uploading existing content
56274e1 
Attempting to upload existing content now returns the href of the
existing unit instead of raising an exception, possibly also adding
the content into a specified repository if it was not there already.

To make this work for a specific plugin, the retrieve() function
has to be implemented in the content serializer specific for the
given plugin. This commit does not break the behavior of plugins
not containing this implementation yet in any way.

closes pulp#3081
MichalPysik added a commit to MichalPysik/pulpcore that referenced this issue Aug 24, 2022
@MichalPysik
Allow uploading existing content
9445a31 
Attempting to upload existing content now returns the href of the
existing unit instead of raising an exception, possibly also adding
the content into a specified repository if it was not there already.

To make this work for a specific plugin, the retrieve() function
has to be implemented in the content serializer specific for the
given plugin. This commit does not break the behavior of plugins
not containing this implementation yet in any way.

closes pulp#3081
MichalPysik added a commit to MichalPysik/pulpcore that referenced this issue Aug 24, 2022
@MichalPysik
Allow uploading existing content
f0927e8 
Attempting to upload existing content now returns the href of the
existing unit instead of raising an exception, possibly also adding
the content into a specified repository if it was not there already.

To make this work for a specific plugin, the retrieve() function
has to be implemented in the content serializer specific for the
given plugin. This commit does not break the behavior of plugins
not containing this implementation yet in any way.

closes pulp#3081
MichalPysik added a commit to MichalPysik/pulpcore that referenced this issue Aug 26, 2022
@MichalPysik
Allow uploading existing content
20fd63c 
Attempting to upload existing content now returns the href of the
existing unit instead of raising an exception, possibly also adding
the content into a specified repository if it was not there already.

To make this work for a specific plugin, the retrieve() function
has to be implemented in the content serializer specific for the
given plugin. This commit does not break the behavior of plugins
not containing this implementation yet in any way.

closes pulp#3081
MichalPysik added a commit to MichalPysik/pulpcore that referenced this issue Sep 5, 2022
@MichalPysik
Allow uploading existing content
79315ad 
Attempting to upload existing content now returns the href of the
existing unit instead of raising an exception, possibly also adding
the content into a specified repository if it was not there already.

To make this work for a specific plugin, the retrieve() function
has to be implemented in the content serializer specific for the
given plugin. This commit does not break the behavior of plugins
not containing this implementation yet in any way.

closes pulp#3081
MichalPysik added a commit to MichalPysik/pulpcore that referenced this issue Sep 5, 2022
@MichalPysik
Allow uploading existing content
982cbd7 
Attempting to upload existing content now returns the href of the
existing unit instead of raising an exception, possibly also adding
the content into a specified repository if it was not there already.

To make this work for a specific plugin, the retrieve() function
has to be implemented in the content serializer specific for the
given plugin. This commit does not break the behavior of plugins
not containing this implementation yet in any way.

closes pulp#3081
MichalPysik added a commit to MichalPysik/pulpcore that referenced this issue Sep 6, 2022
@MichalPysik
Allow uploading existing content
23458a1 
Attempting to upload existing content now returns the href of the
existing unit instead of raising an exception, possibly also adding
the content into a specified repository if it was not there already.

To make this work for a specific plugin, the retrieve() function
has to be implemented in the content serializer specific for the
given plugin. This commit does not break the behavior of plugins
not containing this implementation yet in any way.

closes pulp#3081
MichalPysik added a commit to MichalPysik/pulpcore that referenced this issue Sep 6, 2022
@MichalPysik
Allow uploading existing content
acf9039 
Attempting to upload existing content now returns the href of the
existing unit instead of raising an exception, possibly also adding
the content into a specified repository if it was not there already.

To make this work for a specific plugin, the retrieve() function
has to be implemented in the content serializer specific for the
given plugin. This commit does not break the behavior of plugins
not containing this implementation yet in any way.

closes pulp#3081
MichalPysik added a commit to MichalPysik/pulpcore that referenced this issue Sep 8, 2022
@MichalPysik
Allow uploading existing content
a5931fa 
Attempting to upload existing content now returns the href of the
existing unit instead of raising an exception, possibly also adding
the content into a specified repository if it was not there already.

To make this work for a specific plugin, the retrieve() function
has to be implemented in the content serializer specific for the
given plugin. This commit does not break the behavior of plugins
not containing this implementation yet in any way.

closes pulp#3081
MichalPysik added a commit to MichalPysik/pulpcore that referenced this issue Sep 9, 2022
@MichalPysik
Allow uploading existing content
b8782ce 
Attempting to upload existing content now returns the href of the
existing unit instead of raising an exception, possibly also adding
the content into a specified repository if it was not there already.

To make this work for a specific plugin, the retrieve() function
has to be implemented in the content serializer specific for the
given plugin. This commit does not break the behavior of plugins
not containing this implementation yet in any way.

closes pulp#3081
MichalPysik added a commit to MichalPysik/pulpcore that referenced this issue Sep 9, 2022
@MichalPysik
Allow uploading existing content
8be7336 
Attempting to upload existing content now returns the href of the
existing unit instead of raising an exception, possibly also adding
the content into a specified repository if it was not there already.

To make this work for a specific plugin, the retrieve() function
has to be implemented in the content serializer specific for the
given plugin. This commit does not break the behavior of plugins
not containing this implementation yet in any way.

closes pulp#3081
MichalPysik added a commit to MichalPysik/pulpcore that referenced this issue Sep 9, 2022
@MichalPysik
Allow uploading existing content
983d23d 
Attempting to upload existing content now returns the href of the
existing unit instead of raising an exception, possibly also adding
the content into a specified repository if it was not there already.

To make this work for a specific plugin, the retrieve() function
has to be implemented in the content serializer specific for the
given plugin. This commit does not break the behavior of plugins
not containing this implementation yet in any way.

closes pulp#3081
MichalPysik added a commit to MichalPysik/pulpcore that referenced this issue Sep 9, 2022
@MichalPysik
Allow uploading existing content
9172392 
Attempting to upload existing content now returns the href of the
existing unit instead of raising an exception, possibly also adding
the content into a specified repository if it was not there already.

To make this work for a specific plugin, the retrieve() function
has to be implemented in the content serializer specific for the
given plugin. This commit does not break the behavior of plugins
not containing this implementation yet in any way.

closes pulp#3081
bmbouter pushed a commit that referenced this issue Sep 9, 2022
@MichalPysik @bmbouter
Allow uploading existing content
0f9a524 
Attempting to upload existing content now returns the href of the
existing unit instead of raising an exception, possibly also adding
the content into a specified repository if it was not there already.

To make this work for a specific plugin, the retrieve() function
has to be implemented in the content serializer specific for the
given plugin. This commit does not break the behavior of plugins
not containing this implementation yet in any way.

closes #3081
@daviddavis daviddavis mentioned this issue Oct 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MichalPysik MichalPysik

Labels
Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow uploading existing content MichalPysik/pulpcore
2 participants
@dkliban @MichalPysik